Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7263

xmlparser: Allow SpanQueryBuilder to be used by derived classes

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 6.0
        • Fix Version/s: 5.x, 6.1, 7.0
        • Component/s: modules/queryparser
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          Following on from LUCENE-7210 (and others), the xml queryparser has different factories, one for creating normal queries and one for creating span queries.

          The former is a protected variable so can be used by derived classes, the latter isn't.

          This makes the spanFactory a variable that can be used more easily. No functional changes.

          1. Text File
            LUCENE-7263.patch
            3 kB
            Daniel Collins

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            dancollins Daniel Collins added a comment -

            Don't think there is anything controversial here, its just allowing derived classes access to the span builder, but if anyone sees any issues, let me know

            Show
            dancollins Daniel Collins added a comment - Don't think there is anything controversial here, its just allowing derived classes access to the span builder, but if anyone sees any issues, let me know
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 2fe824fd6e91b00461008b9a6d7e136f87ead716 in lucene-solr's branch refs/heads/master from Christine Poerschke
            [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2fe824f ]

            LUCENE-7263: Make queryparser/xml/CoreParser's SpanQueryBuilderFactory accessible to deriving classes. (Daniel Collins via Christine Poerschke)

            Show
            jira-bot ASF subversion and git services added a comment - Commit 2fe824fd6e91b00461008b9a6d7e136f87ead716 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2fe824f ] LUCENE-7263 : Make queryparser/xml/CoreParser's SpanQueryBuilderFactory accessible to deriving classes. (Daniel Collins via Christine Poerschke)
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 72ce1faecd88870e41f34e48d82ac9369e7b379e in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
            [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=72ce1fa ]

            LUCENE-7263: Make queryparser/xml/CoreParser's SpanQueryBuilderFactory accessible to deriving classes. (Daniel Collins via Christine Poerschke)

            Show
            jira-bot ASF subversion and git services added a comment - Commit 72ce1faecd88870e41f34e48d82ac9369e7b379e in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=72ce1fa ] LUCENE-7263 : Make queryparser/xml/CoreParser's SpanQueryBuilderFactory accessible to deriving classes. (Daniel Collins via Christine Poerschke)
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 8835a45fef8f425feb1af741f87aa9cff13dea91 in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke
            [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8835a45 ]

            LUCENE-7263: Make queryparser/xml/CoreParser's SpanQueryBuilderFactory accessible to deriving classes. (Daniel Collins via Christine Poerschke)

            Show
            jira-bot ASF subversion and git services added a comment - Commit 8835a45fef8f425feb1af741f87aa9cff13dea91 in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8835a45 ] LUCENE-7263 : Make queryparser/xml/CoreParser's SpanQueryBuilderFactory accessible to deriving classes. (Daniel Collins via Christine Poerschke)
            Hide
            Permalink
            cpoerschke Christine Poerschke added a comment -

            Thanks Daniel!

            Show
            cpoerschke Christine Poerschke added a comment - Thanks Daniel!
            Hide
            Permalink
            hossman Hoss Man added a comment -

            Manually correcting fixVersion per Step #S5 of LUCENE-7271

            Show
            hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

              People

              • Assignee:
                cpoerschke Christine Poerschke
                Reporter:
                dancollins Daniel Collins
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development