Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7257

PointValues aggregated stats fail if the provided field does not have points on one of the leaves

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1, 6.0.1, master (7.0)
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The static helpers on PointValues to get aggregated size/docCount/minPackedValue/maxPackedValue fail if a leaf has points indexed (so that getPointValues() returns a non-null value) but not for the given field. In that case PointValues.size() throws an exception.

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch that checks the field infos on each leaf and skips leaves whose field infos report a number of dimensions equal to 0.

        Show
        jpountz Adrien Grand added a comment - Here is a patch that checks the field infos on each leaf and skips leaves whose field infos report a number of dimensions equal to 0.
        Hide
        jpountz Adrien Grand added a comment -

        Alternatively we could throw an exception if none of the leaves have points for the given field, but then I was not sure what should happen in the case of an empty index since it could either be that no documents have ever been indexed or that they were indexed in the past but then got all deleted.

        Show
        jpountz Adrien Grand added a comment - Alternatively we could throw an exception if none of the leaves have points for the given field, but then I was not sure what should happen in the case of an empty index since it could either be that no documents have ever been indexed or that they were indexed in the past but then got all deleted.
        Hide
        mikemccand Michael McCandless added a comment -

        +1, thanks Adrien Grand!

        Show
        mikemccand Michael McCandless added a comment - +1, thanks Adrien Grand !
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dbb28f3cb431cf71133c2da76172a9cae480e3d5 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbb28f3 ]

        LUCENE-7257: PointValues aggregated stats fail if the provided field does not have points on one of the leaves.

        Show
        jira-bot ASF subversion and git services added a comment - Commit dbb28f3cb431cf71133c2da76172a9cae480e3d5 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbb28f3 ] LUCENE-7257 : PointValues aggregated stats fail if the provided field does not have points on one of the leaves.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c7cdf2832bbfbc46d9bfa3cb5041a821fbb7be1d in lucene-solr's branch refs/heads/master from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c7cdf28 ]

        LUCENE-7257: PointValues aggregated stats fail if the provided field does not have points on one of the leaves.

        Show
        jira-bot ASF subversion and git services added a comment - Commit c7cdf2832bbfbc46d9bfa3cb5041a821fbb7be1d in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c7cdf28 ] LUCENE-7257 : PointValues aggregated stats fail if the provided field does not have points on one of the leaves.
        Hide
        jpountz Adrien Grand added a comment -

        Thanks Mike for the review.

        Show
        jpountz Adrien Grand added a comment - Thanks Mike for the review.
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 6.0.1.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 6.0.1.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cbc97f7273d89bdce552bd68dc987f807ea4d404 in lucene-solr's branch refs/heads/branch_6_0 from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbc97f7 ]

        LUCENE-7257: PointValues aggregated stats fail if the provided field does not have points on one of the leaves.

        Show
        jira-bot ASF subversion and git services added a comment - Commit cbc97f7273d89bdce552bd68dc987f807ea4d404 in lucene-solr's branch refs/heads/branch_6_0 from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbc97f7 ] LUCENE-7257 : PointValues aggregated stats fail if the provided field does not have points on one of the leaves.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues included in the 6.0.1 release.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues included in the 6.0.1 release.

          People

          • Assignee:
            jpountz Adrien Grand
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development