Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7243

Remove LeafReaderContext from QueryCachingPolicy.shouldCache

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1, 7.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Now that the heuristic to not cache on small segments has been moved to the cache, we don't need the LeafReaderContext in QueryCachingPolicy.shouldCache.

      1. LUCENE-7243.patch
        10 kB
        Adrien Grand

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Patch.

        Show
        jpountz Adrien Grand added a comment - Patch.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 58852beb8fa87bbfd334e466950154d87ae69913 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=58852be ]

        LUCENE-7243: Removed the LeafReaderContext parameter from QueryCachingPolicy#shouldCache.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 58852beb8fa87bbfd334e466950154d87ae69913 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=58852be ] LUCENE-7243 : Removed the LeafReaderContext parameter from QueryCachingPolicy#shouldCache.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 927a44881c020efd6fa79ad5633c8e96bfa716df in lucene-solr's branch refs/heads/master from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=927a448 ]

        LUCENE-7243: Removed the LeafReaderContext parameter from QueryCachingPolicy#shouldCache.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 927a44881c020efd6fa79ad5633c8e96bfa716df in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=927a448 ] LUCENE-7243 : Removed the LeafReaderContext parameter from QueryCachingPolicy#shouldCache.
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

          People

          • Assignee:
            jpountz Adrien Grand
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development