Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7210

Make TestCore*Parser's analyzer choice override-able

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0, 5.x, 6.x
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Make TestCore[Plus(Queries|Extensions)]Parser's analyzer choice override-able.
      (Christine Poerschke, Daniel Collins)

      1. LUCENE-7210.patch
        12 kB
        Christine Poerschke
      2. LUCENE-7210.patch
        12 kB
        Christine Poerschke

        Activity

        Hide
        cpoerschke Christine Poerschke added a comment -

        The originally proposed patch removed the TestCoreParser.defaultField() method and this alternative patch re-instates it since it could be/is used by other tests such as solr's TestXmlQParser test.

        Show
        cpoerschke Christine Poerschke added a comment - The originally proposed patch removed the TestCoreParser.defaultField() method and this alternative patch re-instates it since it could be/is used by other tests such as solr's TestXmlQParser test.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8d5d2013431608f397cc7f5cd6be682123246983 in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d5d201 ]

        LUCENE-7210: Make TestCore*Parser's analyzer choice override-able. (Christine Poerschke, Daniel Collins)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8d5d2013431608f397cc7f5cd6be682123246983 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d5d201 ] LUCENE-7210 : Make TestCore*Parser's analyzer choice override-able. (Christine Poerschke, Daniel Collins)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8d5d2013431608f397cc7f5cd6be682123246983 in lucene-solr's branch refs/heads/jira/SOLR-8908 from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d5d201 ]

        LUCENE-7210: Make TestCore*Parser's analyzer choice override-able. (Christine Poerschke, Daniel Collins)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8d5d2013431608f397cc7f5cd6be682123246983 in lucene-solr's branch refs/heads/jira/ SOLR-8908 from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d5d201 ] LUCENE-7210 : Make TestCore*Parser's analyzer choice override-able. (Christine Poerschke, Daniel Collins)
        Show
        cpoerschke Christine Poerschke added a comment - from Jenkins: http://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/520/ http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16505/ trying to reproduce locally, no luck so far.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 88c4b095bccb9ffcb7e73fcd39cf4646457e5430 in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=88c4b09 ]

        LUCENE-7210: Add missing @Override to TestCorePlus(Queries|Extensions)Parser's newCoreParser method.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 88c4b095bccb9ffcb7e73fcd39cf4646457e5430 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=88c4b09 ] LUCENE-7210 : Add missing @Override to TestCorePlus(Queries|Extensions)Parser's newCoreParser method.
        Hide
        cpoerschke Christine Poerschke added a comment -

        Committed a fix (88c4b095bccb9ffcb7e73fcd39cf4646457e5430), see below.

        Show
        cpoerschke Christine Poerschke added a comment - Committed a fix (88c4b095bccb9ffcb7e73fcd39cf4646457e5430), see below.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 296d96e4c609d145f621a76d9f2a93b9e11375eb in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=296d96e ]

        LUCENE-7210: Make TestCore*Parser's analyzer choice override-able. (Christine Poerschke, Daniel Collins)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 296d96e4c609d145f621a76d9f2a93b9e11375eb in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=296d96e ] LUCENE-7210 : Make TestCore*Parser's analyzer choice override-able. (Christine Poerschke, Daniel Collins)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 22df9fc3b72b8d1918aa8580d32fc657757df1ef in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=22df9fc ]

        LUCENE-7210: Add missing @Override to TestCorePlus(Queries|Extensions)Parser's newCoreParser method.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 22df9fc3b72b8d1918aa8580d32fc657757df1ef in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=22df9fc ] LUCENE-7210 : Add missing @Override to TestCorePlus(Queries|Extensions)Parser's newCoreParser method.
        Show
        cpoerschke Christine Poerschke added a comment - still/again failing sometimes actually: http://jenkins.thetaphi.de/job/Lucene-Solr-master-MacOSX/3208/ http://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/521/ http://jenkins.thetaphi.de/job/Lucene-Solr-master-Windows/5778/
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b61b8cd5c881c76bfcc834ef3eb1c3f1a6c73287 in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b61b8cd ]

        LUCENE-7210: Make TestCore*Parser's analyzer choice override-able. (Christine Poerschke, Daniel Collins)

        (Merge conflicts resolved.)

        Show
        jira-bot ASF subversion and git services added a comment - Commit b61b8cd5c881c76bfcc834ef3eb1c3f1a6c73287 in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b61b8cd ] LUCENE-7210 : Make TestCore*Parser's analyzer choice override-able. (Christine Poerschke, Daniel Collins) (Merge conflicts resolved.)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2cf9e1d00b5dfe04cb35ff7aff19cbb8c0cb0440 in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2cf9e1d ]

        LUCENE-7210: Add missing @Override to TestCorePlus(Queries|Extensions)Parser's newCoreParser method.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2cf9e1d00b5dfe04cb35ff7aff19cbb8c0cb0440 in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2cf9e1d ] LUCENE-7210 : Add missing @Override to TestCorePlus(Queries|Extensions)Parser's newCoreParser method.
        Hide
        cpoerschke Christine Poerschke added a comment -

        Changes committed to master/branch_6x/branch_5x but sometimes still seeing test failures. Looking into.

        Show
        cpoerschke Christine Poerschke added a comment - Changes committed to master/branch_6x/branch_5x but sometimes still seeing test failures. Looking into.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cb840f5242234737cd3c0390f557f3faa4ad652d in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cb840f5 ]

        LUCENE-7210: TestCoreParser.afterClass now resets (static) indexData/coreParser/analyzer to null.

        Show
        jira-bot ASF subversion and git services added a comment - Commit cb840f5242234737cd3c0390f557f3faa4ad652d in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cb840f5 ] LUCENE-7210 : TestCoreParser.afterClass now resets (static) indexData/coreParser/analyzer to null.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e6bcb131a7f0ddb41c526f97a0327a6fb96a0be0 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e6bcb13 ]

        LUCENE-7210: TestCoreParser.afterClass now resets (static) indexData/coreParser/analyzer to null.

        Show
        jira-bot ASF subversion and git services added a comment - Commit e6bcb131a7f0ddb41c526f97a0327a6fb96a0be0 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e6bcb13 ] LUCENE-7210 : TestCoreParser.afterClass now resets (static) indexData/coreParser/analyzer to null.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ddccac85c2d5b7b714a5637e3579574f92174cad in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ddccac8 ]

        LUCENE-7210: TestCoreParser.afterClass now resets (static) indexData/coreParser/analyzer to null.

        Show
        jira-bot ASF subversion and git services added a comment - Commit ddccac85c2d5b7b714a5637e3579574f92174cad in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ddccac8 ] LUCENE-7210 : TestCoreParser.afterClass now resets (static) indexData/coreParser/analyzer to null.
        Hide
        mikemccand Michael McCandless added a comment -

        Can this be resolved now Christine Poerschke?

        Show
        mikemccand Michael McCandless added a comment - Can this be resolved now Christine Poerschke ?

          People

          • Assignee:
            cpoerschke Christine Poerschke
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development