Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1, master (7.0)
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This is part 1 for LUCENE-7165. This task will add a GeoEncodingUtils helper class to o.a.l.geo in the core module for reusing lat/lon encoding methods. Existing encoding methods in LatLonPoint will be refactored to the new helper class so a new numerically stable morton encoding can be added that reuses the same encoding methods.

      1. LUCENE-7184.patch
        44 kB
        Nicholas Knize
      2. LUCENE-7184.patch
        50 kB
        Nicholas Knize
      3. LUCENE-7184.patch
        51 kB
        Nicholas Knize

        Issue Links

          Activity

          Hide
          nknize Nicholas Knize added a comment -

          Patch includes the following:

          • adds new GeoEncodingUtils to o.a.l.geo package in core module
          • refactors public LatLonPoint.encode* methods to new GeoEncodingUtils helper class
          • adds new TestGeoEncodingUtils to core tests
          • Refactors TestLatLonPoint encoding methods to new TestGeoEncodingUtils class
          Show
          nknize Nicholas Knize added a comment - Patch includes the following: adds new GeoEncodingUtils to o.a.l.geo package in core module refactors public LatLonPoint.encode* methods to new GeoEncodingUtils helper class adds new TestGeoEncodingUtils to core tests Refactors TestLatLonPoint encoding methods to new TestGeoEncodingUtils class
          Hide
          rcmuir Robert Muir added a comment -

          Can we remove the TOLERANCE constant and all uses of it in tests? I just rewrote the encoding tests to remove any epsilon based testing.

          Show
          rcmuir Robert Muir added a comment - Can we remove the TOLERANCE constant and all uses of it in tests? I just rewrote the encoding tests to remove any epsilon based testing.
          Hide
          nknize Nicholas Knize added a comment -

          +1 Will update the patch.

          Show
          nknize Nicholas Knize added a comment - +1 Will update the patch.
          Hide
          nknize Nicholas Knize added a comment -

          Updated patch

          • Removes ENCODING_TOLERANCE
          • Removes TestGeoEncodingUtils.testEncodeDecode to sync with master branch
          Show
          nknize Nicholas Knize added a comment - Updated patch Removes ENCODING_TOLERANCE Removes TestGeoEncodingUtils.testEncodeDecode to sync with master branch
          Hide
          mikemccand Michael McCandless added a comment -

          +1

          Show
          mikemccand Michael McCandless added a comment - +1
          Hide
          nknize Nicholas Knize added a comment -

          I had to rebase from master to catch the test and encoding changes since the patch was posted. Here's one last patch to double check nothing was missed in the rebase.

          Show
          nknize Nicholas Knize added a comment - I had to rebase from master to catch the test and encoding changes since the patch was posted. Here's one last patch to double check nothing was missed in the rebase.
          Hide
          mikemccand Michael McCandless added a comment -

          +1

          Show
          mikemccand Michael McCandless added a comment - +1
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b5ce2f67fdfd1c6fa49eb905a7dfa9b61236c74d in lucene-solr's branch refs/heads/master from nknize
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b5ce2f6 ]

          LUCENE-7184: Refactor LatLonPoint encoding methods to new GeoEncodingUtils helper class in core geo package. Also refactors LatLonPointTests to TestGeoEncodingUtils.

          Show
          jira-bot ASF subversion and git services added a comment - Commit b5ce2f67fdfd1c6fa49eb905a7dfa9b61236c74d in lucene-solr's branch refs/heads/master from nknize [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b5ce2f6 ] LUCENE-7184 : Refactor LatLonPoint encoding methods to new GeoEncodingUtils helper class in core geo package. Also refactors LatLonPointTests to TestGeoEncodingUtils.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6a6f73a26c53a02d6a5267fae88f2ad2e86a6980 in lucene-solr's branch refs/heads/branch_6x from nknize
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6a6f73a ]

          LUCENE-7184: Refactor LatLonPoint encoding methods to new GeoEncodingUtils helper class in core geo package. Also refactors LatLonPointTests to TestGeoEncodingUtils.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6a6f73a26c53a02d6a5267fae88f2ad2e86a6980 in lucene-solr's branch refs/heads/branch_6x from nknize [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6a6f73a ] LUCENE-7184 : Refactor LatLonPoint encoding methods to new GeoEncodingUtils helper class in core geo package. Also refactors LatLonPointTests to TestGeoEncodingUtils.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 455f3dd694c431d9391a910d054d6a599dff59d4 in lucene-solr's branch refs/heads/master from nknize
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=455f3dd ]

          LUCENE-7184: update CHANGES.txt

          Show
          jira-bot ASF subversion and git services added a comment - Commit 455f3dd694c431d9391a910d054d6a599dff59d4 in lucene-solr's branch refs/heads/master from nknize [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=455f3dd ] LUCENE-7184 : update CHANGES.txt
          Hide
          hossman Hoss Man added a comment -

          Manually correcting fixVersion per Step #S5 of LUCENE-7271

          Show
          hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

            People

            • Assignee:
              nknize Nicholas Knize
              Reporter:
              nknize Nicholas Knize
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development