Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      o.a.l.spatial.util.GeoRect and o.a.l.spatial.util.Polygon are reusable classes across multiple lucene modules. It makes sense for them to be moved to the o.a.l.geo package in the core module so they're exposed across multiple modules.

      GeoRect should also be refactored to something more straightforward, like Rectangle

      1. LUCENE-7163.patch
        52 kB
        Nicholas Knize

        Activity

        Hide
        nknize Nicholas Knize added a comment -

        Patch ready for review:

        • refactors GeoRect from spatial module to o.a.l.geo.Rectangle in core module
        • refactors Polygon from spatial module to o.a.l.geo.Polygon in core module
        • refactors TestGeoUtils from spatial module to core tests module
        • refactors GeoTestUtil from spatial module to test-framework module
        • Moves encoding tests from TestGeoUtils to new TestGeoEncodingUtils in spatial module
        • TODO: requires a new (temporary) duplicated TOLERANCE variable in Polygon that currently lives in GeoEncodingUtils. See LUCENE-7165 for reason. This will be removed in 7165.
        Show
        nknize Nicholas Knize added a comment - Patch ready for review: refactors GeoRect from spatial module to o.a.l.geo.Rectangle in core module refactors Polygon from spatial module to o.a.l.geo.Polygon in core module refactors TestGeoUtils from spatial module to core tests module refactors GeoTestUtil from spatial module to test-framework module Moves encoding tests from TestGeoUtils to new TestGeoEncodingUtils in spatial module TODO: requires a new (temporary) duplicated TOLERANCE variable in Polygon that currently lives in GeoEncodingUtils . See LUCENE-7165 for reason. This will be removed in 7165.
        Hide
        rcmuir Robert Muir added a comment -

        +1. I think then we can now maybe remove sandbox/ dependency on spatial/ after refactoring the base class to test framework. I will look into that.

        Show
        rcmuir Robert Muir added a comment - +1. I think then we can now maybe remove sandbox/ dependency on spatial/ after refactoring the base class to test framework. I will look into that.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6c219e99e4b7018ec75430a1eb880566e63d4d63 in lucene-solr's branch refs/heads/master from nknize
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6c219e9 ]

        LUCENE-7163: refactor GeoRect, Polygon, and GeoUtils tests to geo package in core.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6c219e99e4b7018ec75430a1eb880566e63d4d63 in lucene-solr's branch refs/heads/master from nknize [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6c219e9 ] LUCENE-7163 : refactor GeoRect, Polygon, and GeoUtils tests to geo package in core.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 951563aa427ff685d67b3edf55999d72fa945045 in lucene-solr's branch refs/heads/branch_6x from nknize
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=951563a ]

        LUCENE-7163: refactor GeoRect, Polygon, and GeoUtils tests to geo package in core.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 951563aa427ff685d67b3edf55999d72fa945045 in lucene-solr's branch refs/heads/branch_6x from nknize [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=951563a ] LUCENE-7163 : refactor GeoRect, Polygon, and GeoUtils tests to geo package in core.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d30ebffc95d2b837434027d1e4cb7b0a563b6f0c in lucene-solr's branch refs/heads/master from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d30ebff ]

        LUCENE-7163: move Polygon's test too

        Show
        jira-bot ASF subversion and git services added a comment - Commit d30ebffc95d2b837434027d1e4cb7b0a563b6f0c in lucene-solr's branch refs/heads/master from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d30ebff ] LUCENE-7163 : move Polygon's test too
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 741a1e4eedbc88a684baecfcc35ed7cdabcea1b2 in lucene-solr's branch refs/heads/branch_6x from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=741a1e4 ]

        LUCENE-7163: move Polygon's test too

        Show
        jira-bot ASF subversion and git services added a comment - Commit 741a1e4eedbc88a684baecfcc35ed7cdabcea1b2 in lucene-solr's branch refs/heads/branch_6x from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=741a1e4 ] LUCENE-7163 : move Polygon's test too
        Hide
        mikemccand Michael McCandless added a comment -

        Can this be closed now Nicholas Knize?

        Show
        mikemccand Michael McCandless added a comment - Can this be closed now Nicholas Knize ?

          People

          • Assignee:
            Unassigned
            Reporter:
            nknize Nicholas Knize
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development