Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      In org.apache.lucene.index.DocumentWriter. The patch will explain by itself. I didn't make any performance test, but I think it is obvious that it will be faster.
      All tests passed.

      1. DocumentWriter.patch
        1 kB
        Nicolas Lalevée

        Activity

        Hide
        hibou Nicolas Lalevée added a comment -

        About the priority of the issue, I didn't want to set it to "Major", I just forget to set it correctly.

        Show
        hibou Nicolas Lalevée added a comment - About the priority of the issue, I didn't want to set it to "Major", I just forget to set it correctly.
        Hide
        mikemccand Michael McCandless added a comment -

        Thanks for the patch!

        OK, it looks like you're replacing two cases in DocumentWriter.java where we are manually copying arrays with for loops, with calls to System.arraycopy instead. This patch applies cleanly & the unit tests pass. I will commit this.

        Show
        mikemccand Michael McCandless added a comment - Thanks for the patch! OK, it looks like you're replacing two cases in DocumentWriter.java where we are manually copying arrays with for loops, with calls to System.arraycopy instead. This patch applies cleanly & the unit tests pass. I will commit this.
        Hide
        mikemccand Michael McCandless added a comment -

        Committed! Thanks Nicolas – keep the patches coming!

        Show
        mikemccand Michael McCandless added a comment - Committed! Thanks Nicolas – keep the patches coming!
        Hide
        mikemccand Michael McCandless added a comment -

        Closing all issues that were resolved for 2.1.

        Show
        mikemccand Michael McCandless added a comment - Closing all issues that were resolved for 2.1.

          People

          • Assignee:
            Unassigned
            Reporter:
            hibou Nicolas Lalevée
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development