Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7112

WeightedSpanTermExtractor should not always call extractUnknownQuery

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0, 5.5.1
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      WeightedSpanTermExtractor always calls extractUnknownQuery, even if term extraction already succeeded because the query is eg. a phrase query. It should only call this method if it could not find how to extract terms otherwise (eg. in case of a custom query).

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch.

        Show
        jpountz Adrien Grand added a comment - Here is a patch.
        Hide
        dsmiley David Smiley added a comment -

        +1.
        I always wondered why it was the way it was; I figured there was some wisdom to it I just didn't know. Simon Willnauer didn't you add this feature originally?

        Show
        dsmiley David Smiley added a comment - +1. I always wondered why it was the way it was; I figured there was some wisdom to it I just didn't know. Simon Willnauer didn't you add this feature originally?
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 766b144044558272e155e6c29df2b66c7a33a19c in lucene-solr's branch refs/heads/branch_6_0 from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=766b144 ]

        LUCENE-7112: WeightedSpanTermExtractor.extractUnknownQuery is only called on queries that could not be extracted.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 766b144044558272e155e6c29df2b66c7a33a19c in lucene-solr's branch refs/heads/branch_6_0 from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=766b144 ] LUCENE-7112 : WeightedSpanTermExtractor.extractUnknownQuery is only called on queries that could not be extracted.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 259e69b76fe1b6ac4f2dbfbca18cf4c2316ea62f in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=259e69b ]

        LUCENE-7112: WeightedSpanTermExtractor.extractUnknownQuery is only called on queries that could not be extracted.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 259e69b76fe1b6ac4f2dbfbca18cf4c2316ea62f in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=259e69b ] LUCENE-7112 : WeightedSpanTermExtractor.extractUnknownQuery is only called on queries that could not be extracted.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9448bd007b0dbf091c4aa8666b323e0880fb07aa in lucene-solr's branch refs/heads/master from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9448bd0 ]

        LUCENE-7112: WeightedSpanTermExtractor.extractUnknownQuery is only called on queries that could not be extracted.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9448bd007b0dbf091c4aa8666b323e0880fb07aa in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9448bd0 ] LUCENE-7112 : WeightedSpanTermExtractor.extractUnknownQuery is only called on queries that could not be extracted.
        Hide
        mikemccand Michael McCandless added a comment -

        Adrien Grand can this be closed now?

        Show
        mikemccand Michael McCandless added a comment - Adrien Grand can this be closed now?
        Hide
        jpountz Adrien Grand added a comment -

        Absolutely!

        Show
        jpountz Adrien Grand added a comment - Absolutely!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f0fffb60232f6bc6f57da51ffc6de7633ca9093f in lucene-solr's branch refs/heads/branch_5_5 from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f0fffb6 ]

        LUCENE-7112: WeightedSpanTermExtractor.extractUnknownQuery is only called on queries that could not be extracted.

        Show
        jira-bot ASF subversion and git services added a comment - Commit f0fffb60232f6bc6f57da51ffc6de7633ca9093f in lucene-solr's branch refs/heads/branch_5_5 from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f0fffb6 ] LUCENE-7112 : WeightedSpanTermExtractor.extractUnknownQuery is only called on queries that could not be extracted.

          People

          • Assignee:
            jpountz Adrien Grand
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development