Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The join module supports numeric query-time joins but only with the old encoding. We need to deprecate the current support and implement a Points-based alternative.

      1. LUCENE_7095.patch
        31 kB
        Martijn van Groningen
      2. LUCENE_7095.patch
        30 kB
        Martijn van Groningen

        Issue Links

          Activity

          Hide
          martijn.v.groningen Martijn van Groningen added a comment -

          Added a numeric join impl that can work with point values that can be used as a replacement for the legacy numeric join impl.

          Show
          martijn.v.groningen Martijn van Groningen added a comment - Added a numeric join impl that can work with point values that can be used as a replacement for the legacy numeric join impl.
          Hide
          mikemccand Michael McCandless added a comment -

          Whoa, thank you Martijn van Groningen for cutting over joins!

          Show
          mikemccand Michael McCandless added a comment - Whoa, thank you Martijn van Groningen for cutting over joins!
          Hide
          mikemccand Michael McCandless added a comment -

          +1 to the patch.

          The javadocs state that only int and long are supported, yet float and double (strangely, but matching what the legacy numerics join supports?) are also allowed?

          Thanks Martijn van Groningen! The more legacy numerics code we can cut over to points, the better

          Show
          mikemccand Michael McCandless added a comment - +1 to the patch. The javadocs state that only int and long are supported, yet float and double (strangely, but matching what the legacy numerics join supports?) are also allowed? Thanks Martijn van Groningen ! The more legacy numerics code we can cut over to points, the better
          Hide
          martijn.v.groningen Martijn van Groningen added a comment -

          Thanks for reviewing Mike! I've updated the the jdocs.
          I'll push this soon.

          Show
          martijn.v.groningen Martijn van Groningen added a comment - Thanks for reviewing Mike! I've updated the the jdocs. I'll push this soon.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5733f05c70d473415246902641d5ff74a8ba2cbb in lucene-solr's branch refs/heads/branch_6_0 from Martijn van Groningen
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5733f05 ]

          LUCENE-7095: Add point values support to the numeric field query time join

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5733f05c70d473415246902641d5ff74a8ba2cbb in lucene-solr's branch refs/heads/branch_6_0 from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5733f05 ] LUCENE-7095 : Add point values support to the numeric field query time join
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e26a44319429caa8aa28f5c27d620dcbad0dc240 in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e26a443 ]

          LUCENE-7095: Add point values support to the numeric field query time join

          Show
          jira-bot ASF subversion and git services added a comment - Commit e26a44319429caa8aa28f5c27d620dcbad0dc240 in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e26a443 ] LUCENE-7095 : Add point values support to the numeric field query time join
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2babaf8c3d1710280ef53da3d7ba286615e7293e in lucene-solr's branch refs/heads/master from Martijn van Groningen
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2babaf8 ]

          LUCENE-7095: Add point values support to the numeric field query time join

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2babaf8c3d1710280ef53da3d7ba286615e7293e in lucene-solr's branch refs/heads/master from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2babaf8 ] LUCENE-7095 : Add point values support to the numeric field query time join
          Hide
          martijn.v.groningen Martijn van Groningen added a comment -

          Pushed to master, branch_6x and branch_6_0.

          Show
          martijn.v.groningen Martijn van Groningen added a comment - Pushed to master, branch_6x and branch_6_0.

            People

            • Assignee:
              Unassigned
              Reporter:
              rcmuir Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development