Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7087

Change MemoryIndex#fromDocument(...) helpers to accept Iterable<IndexableField> as document

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0, 6.1, 7.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New
    1. LUCENE_7087.patch
      3 kB
      Martijn van Groningen
    2. LUCENE_7087.patch
      2 kB
      Martijn van Groningen

      Activity

      Hide
      romseygeek Alan Woodward added a comment -

      +1

      Show
      romseygeek Alan Woodward added a comment - +1
      Hide
      jpountz Adrien Grand added a comment -

      Can you make it Iterable<? extends IndexableField> instead (like IndexWriter) so that it is fine to pass eg. a List<Field>.

      Show
      jpountz Adrien Grand added a comment - Can you make it Iterable<? extends IndexableField> instead (like IndexWriter) so that it is fine to pass eg. a List<Field> .
      Hide
      martijn.v.groningen Martijn van Groningen added a comment -

      Thanks, Alan and Adrien. I've updated the patch.

      Show
      martijn.v.groningen Martijn van Groningen added a comment - Thanks, Alan and Adrien. I've updated the patch.
      Hide
      jpountz Adrien Grand added a comment -

      +1

      Show
      jpountz Adrien Grand added a comment - +1
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 73db4cab6a7f4948e803f649759781c84fbb3e3f in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=73db4ca ]

      LUCENE-7087: Let MemoryIndex#fromDocument(...) accept 'Iterable<? extends IndexableField>' as document instead of 'Document'

      Show
      jira-bot ASF subversion and git services added a comment - Commit 73db4cab6a7f4948e803f649759781c84fbb3e3f in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=73db4ca ] LUCENE-7087 : Let MemoryIndex#fromDocument(...) accept 'Iterable<? extends IndexableField>' as document instead of 'Document'
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0b8b16f9f281f10d730019f6e291b31f42b936c7 in lucene-solr's branch refs/heads/master from Martijn van Groningen
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0b8b16f ]

      LUCENE-7087: Let MemoryIndex#fromDocument(...) accept 'Iterable<? extends IndexableField>' as document instead of 'Document'

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0b8b16f9f281f10d730019f6e291b31f42b936c7 in lucene-solr's branch refs/heads/master from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0b8b16f ] LUCENE-7087 : Let MemoryIndex#fromDocument(...) accept 'Iterable<? extends IndexableField>' as document instead of 'Document'
      Hide
      martijn.v.groningen Martijn van Groningen added a comment -

      pushed to 6x and master branches

      Show
      martijn.v.groningen Martijn van Groningen added a comment - pushed to 6x and master branches
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 118b8965ce4a56e57b57f8ba7f0bf3fa8bac5250 in lucene-solr's branch refs/heads/branch_6_0 from Martijn van Groningen
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=118b896 ]

      LUCENE-7087: Let MemoryIndex#fromDocument(...) accept 'Iterable<? extends IndexableField>' as document instead of 'Document'

      Show
      jira-bot ASF subversion and git services added a comment - Commit 118b8965ce4a56e57b57f8ba7f0bf3fa8bac5250 in lucene-solr's branch refs/heads/branch_6_0 from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=118b896 ] LUCENE-7087 : Let MemoryIndex#fromDocument(...) accept 'Iterable<? extends IndexableField>' as document instead of 'Document'
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 13ce0815a72abca783b1bed89f04b14071306d9e in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=13ce081 ]

      Change entry to reflect that LUCENE-7087 has been backported to 6.0

      Show
      jira-bot ASF subversion and git services added a comment - Commit 13ce0815a72abca783b1bed89f04b14071306d9e in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=13ce081 ] Change entry to reflect that LUCENE-7087 has been backported to 6.0
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 8185c8a11dbfd170b046e4239b0222b5b0bf2007 in lucene-solr's branch refs/heads/master from Martijn van Groningen
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8185c8a ]

      Change entry to reflect that LUCENE-7087 has been backported to 6.0

      Show
      jira-bot ASF subversion and git services added a comment - Commit 8185c8a11dbfd170b046e4239b0222b5b0bf2007 in lucene-solr's branch refs/heads/master from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8185c8a ] Change entry to reflect that LUCENE-7087 has been backported to 6.0
      Hide
      hossman Hoss Man added a comment -

      Manually correcting fixVersion per Step #S6 of LUCENE-7271

      Show
      hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S6 of LUCENE-7271

        People

        • Assignee:
          Unassigned
          Reporter:
          martijn.v.groningen Martijn van Groningen
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development