[LUCENE-7080] MockDirectoryWrapper relies on HashSet iteration order

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.5, 6.0
• Fix Version/s: 6.0, 6.1, 7.0
• Component/s: general/test
• Lucene Fields: New
• Assignee: Simon Willnauer
• Reporter: Simon Willnauer
• Created: 08/Mar/16 14:45
• Updated: 28/Aug/22 14:51
• Resolved: 09/Mar/16 10:08

Description

MDW relies on HashSet iteration order in

  public synchronized void corruptFiles(Collection<String> files) throws IOException {
    // Must make a copy because we change the incoming unsyncedFiles
    // when we create temp files, delete, etc., below:
    for(String name : new ArrayList<>(files)) { // <<<<< this should be sorted
      int damage = randomState.nextInt(6);

this causes reproducibility issues when files get corrupted.