Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7072

Geo3dPointField should always use WGS84 planet model

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Right now it takes any PlanetModel, but I think that's dangerous.

      First, WGS84 is the most accurate one we have, and second, the planet model is secretly baked into the index via the "planetMax" normalization. I think for Lucene we should only expose WGS84 ...

      1. LUCENE-7072.patch
        13 kB
        Michael McCandless

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        Patch.

        Show
        mikemccand Michael McCandless added a comment - Patch.
        Hide
        rcmuir Robert Muir added a comment -

        +1, this is a great simplification to the api!

        Show
        rcmuir Robert Muir added a comment - +1, this is a great simplification to the api!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b79067a45687e7e41e7db9980643c00c889c2adc in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b79067a ]

        LUCENE-7072: always use WGS84 planet model in Geo3DPoint

        Show
        jira-bot ASF subversion and git services added a comment - Commit b79067a45687e7e41e7db9980643c00c889c2adc in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b79067a ] LUCENE-7072 : always use WGS84 planet model in Geo3DPoint
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 267e326dbf137de5357e0aca7418f648752cb22a in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=267e326 ]

        LUCENE-7072: always use WGS84 planet model in Geo3DPoint

        Show
        jira-bot ASF subversion and git services added a comment - Commit 267e326dbf137de5357e0aca7418f648752cb22a in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=267e326 ] LUCENE-7072 : always use WGS84 planet model in Geo3DPoint
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ac8523d6886cd5c3cdc280b898542e53e4d2f0a9 in lucene-solr's branch refs/heads/branch_6_0 from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ac8523d ]

        LUCENE-7072: always use WGS84 planet model in Geo3DPoint

        Show
        jira-bot ASF subversion and git services added a comment - Commit ac8523d6886cd5c3cdc280b898542e53e4d2f0a9 in lucene-solr's branch refs/heads/branch_6_0 from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ac8523d ] LUCENE-7072 : always use WGS84 planet model in Geo3DPoint

          People

          • Assignee:
            mikemccand Michael McCandless
            Reporter:
            mikemccand Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development