Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7065

Fix explain for global ordinal query time join

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0, 5.5.2, 5.6
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The explain methods for the global ordinal join is broken, because even in the case that a document doesn't match with the query it tries to create an explain that tells it does.

      In the case when score mode 'avg' is used this causes a NPE and in the other cases the return explanation indicates that a document matches while it doesn't.

      1. LUCENE_7065.patch
        9 kB
        Martijn van Groningen
      2. LUCENE_7065.patch
        9 kB
        Martijn van Groningen

        Activity

        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        Patch with the fix and a test.

        Show
        martijn.v.groningen Martijn van Groningen added a comment - Patch with the fix and a test.
        Hide
        jpountz Adrien Grand added a comment -

        Maybe the explanation descriptions should be more explicit: I think it could be interesting to know that a document has no join value vs. it has one but it does not match.

        Show
        jpountz Adrien Grand added a comment - Maybe the explanation descriptions should be more explicit: I think it could be interesting to know that a document has no join value vs. it has one but it does not match.
        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        +1 I'll improve the descriptions.

        Show
        martijn.v.groningen Martijn van Groningen added a comment - +1 I'll improve the descriptions.
        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        I've attached a new patch with improved explain descriptions.

        Show
        martijn.v.groningen Martijn van Groningen added a comment - I've attached a new patch with improved explain descriptions.
        Hide
        jpountz Adrien Grand added a comment -

        +1 I think we should just use Term.toString instead of BytesRef.utf8ToString since the values might not be utf8-encoded.

        Show
        jpountz Adrien Grand added a comment - +1 I think we should just use Term.toString instead of BytesRef.utf8ToString since the values might not be utf8-encoded.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b9cc15309ce42f3e33033bdaad91fbe4737f6fcd in lucene-solr's branch refs/heads/master from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b9cc153 ]

        LUCENE-7065: Fix the explain for the global ordinals join query. Before the
        explain would also indicate that non matching documents would match.
        On top of that with score mode average, the explain would fail with a NPE.

        Show
        jira-bot ASF subversion and git services added a comment - Commit b9cc15309ce42f3e33033bdaad91fbe4737f6fcd in lucene-solr's branch refs/heads/master from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b9cc153 ] LUCENE-7065 : Fix the explain for the global ordinals join query. Before the explain would also indicate that non matching documents would match. On top of that with score mode average, the explain would fail with a NPE.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d700b149a5597b4b8cdd10a5850d6050b6a82107 in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d700b14 ]

        LUCENE-7065: Fix the explain for the global ordinals join query. Before the
        explain would also indicate that non matching documents would match.
        On top of that with score mode average, the explain would fail with a NPE.

        Show
        jira-bot ASF subversion and git services added a comment - Commit d700b149a5597b4b8cdd10a5850d6050b6a82107 in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d700b14 ] LUCENE-7065 : Fix the explain for the global ordinals join query. Before the explain would also indicate that non matching documents would match. On top of that with score mode average, the explain would fail with a NPE.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ac7f15e372963288e922d800d51a30470ebb90aa in lucene-solr's branch refs/heads/branch_6_0 from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ac7f15e ]

        LUCENE-7065: Fix the explain for the global ordinals join query. Before the
        explain would also indicate that non matching documents would match.
        On top of that with score mode average, the explain would fail with a NPE.

        Show
        jira-bot ASF subversion and git services added a comment - Commit ac7f15e372963288e922d800d51a30470ebb90aa in lucene-solr's branch refs/heads/branch_6_0 from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ac7f15e ] LUCENE-7065 : Fix the explain for the global ordinals join query. Before the explain would also indicate that non matching documents would match. On top of that with score mode average, the explain would fail with a NPE.
        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        Thanks Adrien! I pushed this to 6_0, 6x and master branches.

        Show
        martijn.v.groningen Martijn van Groningen added a comment - Thanks Adrien! I pushed this to 6_0, 6x and master branches.
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 5.6 and 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 5.6 and 5.5.2.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dac7ea81704ef708e37b9e7902a29a8e2243b183 in lucene-solr's branch refs/heads/branch_5_5 from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dac7ea8 ]

        LUCENE-7065: Fix the explain for the global ordinals join query. Before the
        explain would also indicate that non matching documents would match.
        On top of that with score mode average, the explain would fail with a NPE.

        Show
        jira-bot ASF subversion and git services added a comment - Commit dac7ea81704ef708e37b9e7902a29a8e2243b183 in lucene-solr's branch refs/heads/branch_5_5 from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dac7ea8 ] LUCENE-7065 : Fix the explain for the global ordinals join query. Before the explain would also indicate that non matching documents would match. On top of that with score mode average, the explain would fail with a NPE.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a92f330a42ee898cc5ceaa5b0676f5fb7d2b5d9e in lucene-solr's branch refs/heads/branch_5x from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a92f330 ]

        LUCENE-7065: Fix the explain for the global ordinals join query. Before the
        explain would also indicate that non matching documents would match.
        On top of that with score mode average, the explain would fail with a NPE.

        Show
        jira-bot ASF subversion and git services added a comment - Commit a92f330a42ee898cc5ceaa5b0676f5fb7d2b5d9e in lucene-solr's branch refs/heads/branch_5x from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a92f330 ] LUCENE-7065 : Fix the explain for the global ordinals join query. Before the explain would also indicate that non matching documents would match. On top of that with score mode average, the explain would fail with a NPE.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues released with 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues released with 5.5.2.

          People

          • Assignee:
            Unassigned
            Reporter:
            martijn.v.groningen Martijn van Groningen
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development