Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7048

Add XXXPoint.newSetQuery to match a set of points

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This is the analog of TermsQuery for dimensional points, to (relatively) efficiently match any docs whose point value is in the specified set.

      1. LUCENE-7048.patch
        74 kB
        Michael McCandless
      2. LUCENE-7048.patch
        67 kB
        Michael McCandless

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        I added newSetQuery to Int,Long,Float,Double,Binary,InetAddress,BigIntegerPoint.

        I also found a bug in how we were encoding float/double, such that the range and set queries were not working!

        I haven't yet tackled the > 1D case yet ...

        Show
        mikemccand Michael McCandless added a comment - I added newSetQuery to Int,Long,Float,Double,Binary,InetAddress,BigIntegerPoint. I also found a bug in how we were encoding float/double, such that the range and set queries were not working! I haven't yet tackled the > 1D case yet ...
        Hide
        rcmuir Robert Muir added a comment -

        +1.

        Show
        rcmuir Robert Muir added a comment - +1.
        Hide
        mikemccand Michael McCandless added a comment -

        New patch, fixing nocommits.

        I didn't add the multi-dim'd versions to all XXXPoint fields, but I did add test cases showing that it works and showing how we could add it "for real" later.

        I think it's ready.

        Show
        mikemccand Michael McCandless added a comment - New patch, fixing nocommits. I didn't add the multi-dim'd versions to all XXXPoint fields, but I did add test cases showing that it works and showing how we could add it "for real" later. I think it's ready.
        Hide
        rcmuir Robert Muir added a comment -

        still looks good. thanks Mike.

        Show
        rcmuir Robert Muir added a comment - still looks good. thanks Mike.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 446ce8604e4baff4f4e486e39f7e885f0d8d0c57 in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=446ce86 ]

        LUCENE-7048: add XXXPoint.newSetQuery to match documents with any values from the specified set (this is the analog of TermsQuery, for points)

        Merge branch 'point_set_query'

        Show
        jira-bot ASF subversion and git services added a comment - Commit 446ce8604e4baff4f4e486e39f7e885f0d8d0c57 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=446ce86 ] LUCENE-7048 : add XXXPoint.newSetQuery to match documents with any values from the specified set (this is the analog of TermsQuery, for points) Merge branch 'point_set_query'
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b9d46e4fd6de73524be7bb4be0b35c066fed4fae in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b9d46e4 ]

        LUCENE-7048: add changes entry

        Show
        jira-bot ASF subversion and git services added a comment - Commit b9d46e4fd6de73524be7bb4be0b35c066fed4fae in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b9d46e4 ] LUCENE-7048 : add changes entry

          People

          • Assignee:
            mikemccand Michael McCandless
            Reporter:
            mikemccand Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development