Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Followup of LUCENE-7039.

      I started consolidating encode/decode functions into XYZField, but its still pretty messy. Specifically, duplicated code because indexer wants packed byte[] and queries want byte[][] and so on.

      We can do a bit more cleanup: by defining everything in terms of encodeDimension() and decodeDimension(). This way, the logic is only in one place.

      Also the new NumericUtils methods here are confusing I think. Its scary how they take a "dimensional index" when parsing from a byte[]. I think they should just take 'offset' and not try to be fancy, its easier to understand.

      1. LUCENE-7042.patch
        114 kB
        Robert Muir

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9ca1a19b81448594bbaf046da5d5e33228e6974f in lucene-solr's branch refs/heads/master from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ca1a19 ]

        LUCENE-7042: more cleanup for Point encodings

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9ca1a19b81448594bbaf046da5d5e33228e6974f in lucene-solr's branch refs/heads/master from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ca1a19 ] LUCENE-7042 : more cleanup for Point encodings
        Hide
        mikemccand Michael McCandless added a comment -

        +1, thanks Robert Muir!

        Show
        mikemccand Michael McCandless added a comment - +1, thanks Robert Muir !

          People

          • Assignee:
            Unassigned
            Reporter:
            rcmuir Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development