Lucene - Core
  1. Lucene - Core
  2. LUCENE-7028

Remove useless clone of method in Lucene 6' LegacyNumericUtils

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      While working on LUCENE-7027 I noticed, that NumericUtils contains the same method 2 times (same signature), one just delegating to the other. I will remove the duplicate for 6.0.

      1. LUCENE-7028.patch
        17 kB
        Uwe Schindler
      2. LUCENE-7028.patch
        8 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment -

          Patch.

          I decided to remove the older method (which should have been deprecated already). In both cases some other parts in Lucene and Solr had to be modified.

          Should I deprecate in 5.x / 5.5?

          Show
          Uwe Schindler added a comment - Patch. I decided to remove the older method (which should have been deprecated already). In both cases some other parts in Lucene and Solr had to be modified. Should I deprecate in 5.x / 5.5?
          Hide
          Uwe Schindler added a comment -

          I prefer this variant more, because it keeps the shorter method name. Its a bit more changes, but overall this is more consistent naming (also with reverse prefixCodedToLong naming).

          Show
          Uwe Schindler added a comment - I prefer this variant more, because it keeps the shorter method name. Its a bit more changes, but overall this is more consistent naming (also with reverse prefixCodedToLong naming).
          Hide
          Michael McCandless added a comment -

          +1 to patch

          I don't think we need to deprecate in 5.5? These are @lucene.internal?

          Show
          Michael McCandless added a comment - +1 to patch I don't think we need to deprecate in 5.5? These are @lucene.internal?
          Hide
          Uwe Schindler added a comment -

          The whole class was renamed anyways, so I am not sure oif its really needed to deprecate. Anybody using Numeric* has to rewrite code anyways.

          Nevertheless, I would just deprecate the method in 5.x and not change any code elsewhere (like this patch does).

          Show
          Uwe Schindler added a comment - The whole class was renamed anyways, so I am not sure oif its really needed to deprecate. Anybody using Numeric* has to rewrite code anyways. Nevertheless, I would just deprecate the method in 5.x and not change any code elsewhere (like this patch does).
          Hide
          ASF subversion and git services added a comment -

          Commit 74421d729b5a04f9342a90ef950e7ece4c113de6 in lucene-solr's branch refs/heads/master from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=74421d7 ]

          LUCENE-7028: Remove duplicate method in LegacyNumericUtils

          Show
          ASF subversion and git services added a comment - Commit 74421d729b5a04f9342a90ef950e7ece4c113de6 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=74421d7 ] LUCENE-7028 : Remove duplicate method in LegacyNumericUtils
          Hide
          ASF subversion and git services added a comment -

          Commit dd6057e79f34b5d30ca2a5fdafabac64cdec9c2a in lucene-solr's branch refs/heads/master from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dd6057e ]

          LUCENE-7028: Add changes for 5.5

          Show
          ASF subversion and git services added a comment - Commit dd6057e79f34b5d30ca2a5fdafabac64cdec9c2a in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dd6057e ] LUCENE-7028 : Add changes for 5.5
          Hide
          ASF subversion and git services added a comment -

          Commit 3e5e548472ca7c285b76a610684f0c87d13e9572 in lucene-solr's branch refs/heads/branch_5x from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3e5e548 ]

          LUCENE-7028: Deprecate a duplicate method in NumericUtils

          Show
          ASF subversion and git services added a comment - Commit 3e5e548472ca7c285b76a610684f0c87d13e9572 in lucene-solr's branch refs/heads/branch_5x from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3e5e548 ] LUCENE-7028 : Deprecate a duplicate method in NumericUtils
          Hide
          ASF subversion and git services added a comment -

          Commit a011c1692bba52c1f7b430b9bb4d03001fc1034a in lucene-solr's branch refs/heads/branch_5x from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a011c16 ]

          LUCENE-7028: Fix typo

          Show
          ASF subversion and git services added a comment - Commit a011c1692bba52c1f7b430b9bb4d03001fc1034a in lucene-solr's branch refs/heads/branch_5x from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a011c16 ] LUCENE-7028 : Fix typo
          Hide
          ASF subversion and git services added a comment -

          Commit 528fb8702b91aaeb7a0491a638ed10ae8ae57f2c in lucene-solr's branch refs/heads/branch_5_5 from Uwe Schindler
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=528fb87 ]

          LUCENE-7028: Deprecate a duplicate method in NumericUtils

          Show
          ASF subversion and git services added a comment - Commit 528fb8702b91aaeb7a0491a638ed10ae8ae57f2c in lucene-solr's branch refs/heads/branch_5_5 from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=528fb87 ] LUCENE-7028 : Deprecate a duplicate method in NumericUtils
          Hide
          Uwe Schindler added a comment -

          In addition to the removal in master, I deprecated in 5.5

          Show
          Uwe Schindler added a comment - In addition to the removal in master, I deprecated in 5.5
          Hide
          Michael McCandless added a comment -

          OK, thanks Uwe Schindler, I'll respin 5.5 now.

          Show
          Michael McCandless added a comment - OK, thanks Uwe Schindler , I'll respin 5.5 now.

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development