Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6998

We should detect truncation for all index files

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.4.2, 5.5, 6.0
    • None
    • None
    • New

    Description

      rcmuir noticed that Lucene60PointReader does not detect truncation of its data file on reader init ... so I added a test to catch this, confirmed it caught the bug, and fixed the bug, and fixed a couple other things uncovered by the test.

      I also improved the other TestAllFiles* tests to use LineFileDocs so they index points, and it caught another bug in Lucene60PointFormat (using the same codec name in two files).

      There is more to do here, e.g. we also need a test that catches places where we fail to check the index header on init, which was also missing for Lucene60PointReader.

      Attachments

        1. LUCENE-6998.patch
          19 kB
          Michael McCandless
        2. LUCENE-6998.patch
          19 kB
          Michael McCandless
        3. LUCENE-6998.patch
          30 kB
          Michael McCandless

        Activity

          People

            mikemccand Michael McCandless
            mikemccand Michael McCandless
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: