Lucene - Core
  1. Lucene - Core
  2. LUCENE-6980

Default to applying deletes when opening NRT reader from writer

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0, 5.x
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today, DirectoryReader.open, etc., all require you to pass a
      supremely expert boolean applyDeletes. I think the vast majority
      of users should just default this to true.

      1. LUCENE-6980.patch
        86 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Simple rote patch.

        Show
        Michael McCandless added a comment - Simple rote patch.
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1725160 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1725160 ]

        LUCENE-6980: default applyDeletes to true when opening NRT readers

        Show
        ASF subversion and git services added a comment - Commit 1725160 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1725160 ] LUCENE-6980 : default applyDeletes to true when opening NRT readers
        Hide
        ASF subversion and git services added a comment -

        Commit 1725162 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1725162 ]

        LUCENE-6980: default applyDeletes to true when opening NRT readers

        Show
        ASF subversion and git services added a comment - Commit 1725162 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1725162 ] LUCENE-6980 : default applyDeletes to true when opening NRT readers
        Hide
        ASF subversion and git services added a comment -

        Commit 1726106 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1726106 ]

        LUCENE-6980: fix a few more tests to just use default (true) for applyAllDeletes

        Show
        ASF subversion and git services added a comment - Commit 1726106 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1726106 ] LUCENE-6980 : fix a few more tests to just use default (true) for applyAllDeletes
        Hide
        ASF subversion and git services added a comment -

        Commit 1726109 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1726109 ]

        LUCENE-6980: fix a few more tests to just use default (true) for applyAllDeletes

        Show
        ASF subversion and git services added a comment - Commit 1726109 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1726109 ] LUCENE-6980 : fix a few more tests to just use default (true) for applyAllDeletes
        Hide
        ASF subversion and git services added a comment -

        Commit 1726250 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1726250 ]

        LUCENE-6980: fix a few more places to just use default (true) for applyAllDeletes

        Show
        ASF subversion and git services added a comment - Commit 1726250 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1726250 ] LUCENE-6980 : fix a few more places to just use default (true) for applyAllDeletes
        Hide
        ASF subversion and git services added a comment -

        Commit 1726262 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1726262 ]

        LUCENE-6980: fix a few more places to just use default (true) for applyAllDeletes

        Show
        ASF subversion and git services added a comment - Commit 1726262 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1726262 ] LUCENE-6980 : fix a few more places to just use default (true) for applyAllDeletes

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development