[LUCENE-6976] BytesTermAttributeImpl.copyTo NPEs when the BytesRef is null

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.4.2, 5.5
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 14/Jan/16 07:03
• Updated: 28/Aug/22 14:48
• Resolved: 10/Feb/16 16:28

Description

The BytesTermAttributeImpl class, not used much I think, has a problem in its copyTo method in which it assumes "bytes" isn't null since it calls BytesRef.deepCopyOf on it. Perhaps deepCopyOf should support null? And also, toString(), equals() and hashCode() aren't implemented but we can do so.
This was discovered in SOLR-8541; the spatial PrefixTreeStrategy uses this attribute and the CachingTokenFilter when used on the analysis chain will call clearAttributes() in it's end() method and then capture the state so it can be replayed later. BytesTermAttributeImpl.clear() nulls out the bytes reference.

Issue Links

• is duplicated by: SOLR-8541 NPE in spatial field highlighting