Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6970

Off-by-one error in Lucene54DocValuesProducer

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.4
    • Fix Version/s: 5.5, 6.0, 5.4.1
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This was found by this build failure: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/15210/

      If the doc count is a multiple of 65534 minus one and the segment is storing binary, sorted set or sorted numeric doc values then you may hit an error when reading values that is due to an off-by-one error in Lucene54DocValuesProducer. This was introduced in LUCENE-6840.

      I'll upload a patch shortly.

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch.

        Show
        jpountz Adrien Grand added a comment - Here is a patch.
        Hide
        rcmuir Robert Muir added a comment -

        It took quite some time for jenkins to find this bug. Is there a non-Slow test that could do the trick? I have concerns about how often these tests run.

        Show
        rcmuir Robert Muir added a comment - It took quite some time for jenkins to find this bug. Is there a non-Slow test that could do the trick? I have concerns about how often these tests run.
        Hide
        jpountz Adrien Grand added a comment -

        Maybe I should just remove the Slow annotation then? These tests take between 1 and 2 secs on my machine. Sorry for my ignorance, but do we have builds that skip the slow tests (I thought this only applied to Nightly).

        Show
        jpountz Adrien Grand added a comment - Maybe I should just remove the Slow annotation then? These tests take between 1 and 2 secs on my machine. Sorry for my ignorance, but do we have builds that skip the slow tests (I thought this only applied to Nightly).
        Hide
        rcmuir Robert Muir added a comment -

        thanks for the explanation, I guess the existing test was found with the huge multiplier only?

        +1 for patch

        Show
        rcmuir Robert Muir added a comment - thanks for the explanation, I guess the existing test was found with the huge multiplier only? +1 for patch
        Hide
        jpountz Adrien Grand added a comment -

        I guess the existing test was found with the huge multiplier only?

        This is correct.

        Show
        jpountz Adrien Grand added a comment - I guess the existing test was found with the huge multiplier only? This is correct.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1724089 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1724089 ]

        LUCENE-6970: Fixed off-by-one error in Lucene54DocValuesProducer.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1724089 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1724089 ] LUCENE-6970 : Fixed off-by-one error in Lucene54DocValuesProducer.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1724091 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1724091 ]

        LUCENE-6970: Fixed off-by-one error in Lucene54DocValuesProducer.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1724091 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1724091 ] LUCENE-6970 : Fixed off-by-one error in Lucene54DocValuesProducer.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1724093 from Adrien Grand in branch 'dev/branches/lucene_solr_5_4'
        [ https://svn.apache.org/r1724093 ]

        LUCENE-6970: Fixed off-by-one error in Lucene54DocValuesProducer.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1724093 from Adrien Grand in branch 'dev/branches/lucene_solr_5_4' [ https://svn.apache.org/r1724093 ] LUCENE-6970 : Fixed off-by-one error in Lucene54DocValuesProducer.

          People

          • Assignee:
            jpountz Adrien Grand
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development