Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6959

Remove ToParentBlockJoinCollector

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 6.5, 7.0
    • None
    • None
    • New

    Description

      This collector uses the getWeight() and getChildren() methods from the passed in Scorer, which are not always available (eg. disjunctions expose fake scorers) hence the need for a dedicated IndexSearcher (ToParentBlockJoinIndexSearcher). Given that this is the only collector in this case, I would like to remove it.

      Attachments

        1. LUCENE-6959.patch
          59 kB
          Adrien Grand
        2. LUCENE_6959.patch
          77 kB
          Martijn van Groningen
        3. LUCENE_6959.patch
          76 kB
          Martijn van Groningen
        4. LUCENE_6959.patch
          76 kB
          Martijn van Groningen
        5. LUCENE_6959.patch
          76 kB
          Martijn van Groningen
        6. LUCENE_6959.patch
          83 kB
          Martijn van Groningen

        Issue Links

          is depended upon by

          Sub-task - The sub-task of the issue SOLR-8643 remove BlockJoinFacetComponent; was: UnsupportedOperationException in FakeScorer

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LUCENE-6229 Remove Scorer.getChildren?

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. LUCENE-6228 Do not expose full-fledged scorers in LeafCollector.setScorer

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. LUCENE-7654 To-parent block joins should implement two-phase iteration

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              jpountz Adrien Grand
              jpountz Adrien Grand
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: