Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6959

Remove ToParentBlockJoinCollector

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 6.5, 7.0
    • None
    • None
    • New

    Description

      This collector uses the getWeight() and getChildren() methods from the passed in Scorer, which are not always available (eg. disjunctions expose fake scorers) hence the need for a dedicated IndexSearcher (ToParentBlockJoinIndexSearcher). Given that this is the only collector in this case, I would like to remove it.

      Attachments

        1. LUCENE_6959.patch
          83 kB
          Martijn van Groningen
        2. LUCENE_6959.patch
          76 kB
          Martijn van Groningen
        3. LUCENE_6959.patch
          76 kB
          Martijn van Groningen
        4. LUCENE_6959.patch
          76 kB
          Martijn van Groningen
        5. LUCENE_6959.patch
          77 kB
          Martijn van Groningen
        6. LUCENE-6959.patch
          59 kB
          Adrien Grand

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jpountz Adrien Grand
            jpountz Adrien Grand
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment