Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6952

All Filter* delegating classes should be abstract

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I think it's confusing that FilterLeafReader (and it's Filter* inner classes) are not abstract. By making them abstract, we clarify to users how to use them by virtue of them being abstract. It seems only a couple tests directly instantiate them. This applies to other Filter* classes as well.

        Attachments

        1. LUCENE_6952.patch
          12 kB
          David Smiley
        2. LUCENE_6952.patch
          13 kB
          David Smiley

          Activity

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              dsmiley David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: