Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6952

All Filter* delegating classes should be abstract

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 6.0
    • None
    • None
    • New

    Description

      I think it's confusing that FilterLeafReader (and it's Filter* inner classes) are not abstract. By making them abstract, we clarify to users how to use them by virtue of them being abstract. It seems only a couple tests directly instantiate them. This applies to other Filter* classes as well.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dsmiley David Smiley
            dsmiley David Smiley
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment