Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6947

SortField.missingValue should not be public

        Details

        • Type: Task
        • Status: Resolved
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 6.0
        • Component/s: None
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          Today we have SortField.setMissingValue that tries to perform validation of the missing value, except that given that SortField.missingValue is public, it is very easy to bypass it. Let's make it protected (some sub-classes use it) and add a getter.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jpountz Adrien Grand added a comment -

            Here is a patch.

            Show
            jpountz Adrien Grand added a comment - Here is a patch.
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            +1

            Show
            mikemccand Michael McCandless added a comment - +1
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1721411 from Adrien Grand in branch 'dev/trunk'
            [ https://svn.apache.org/r1721411 ]

            LUCENE-6947: Hide SortField.missingValue behind a getter.

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1721411 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1721411 ] LUCENE-6947 : Hide SortField.missingValue behind a getter.

              People

              • Assignee:
                jpountz Adrien Grand
                Reporter:
                jpountz Adrien Grand
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development