Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6944

BooleanWeight.bulkScorer should not build any sub bulk scorer if there are required/prohibited clauses

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      BooleanWeight.bulkScorer creates a sub bulk scorer for all clauses until it meets a clause that is not optional (the only kind of clause it can deal with). However the Weight.bulkScorer method is sometimes costly, so BooleanWeight.bulkScorer should first inspect all clauses to see if any of them is not optional to avoid creating costly bulk scorers to only trash them later.

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch.

        Show
        jpountz Adrien Grand added a comment - Here is a patch.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1721215 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1721215 ]

        LUCENE-6944: Prevent BooleanWeight from creating sub bulk-scorers to only trash them later.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1721215 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1721215 ] LUCENE-6944 : Prevent BooleanWeight from creating sub bulk-scorers to only trash them later.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1721221 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1721221 ]

        LUCENE-6944: Prevent BooleanWeight from creating sub bulk-scorers to only trash them later.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1721221 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1721221 ] LUCENE-6944 : Prevent BooleanWeight from creating sub bulk-scorers to only trash them later.
        Hide
        mikemccand Michael McCandless added a comment -

        Adrien Grand can this be resolved now?

        Show
        mikemccand Michael McCandless added a comment - Adrien Grand can this be resolved now?
        Hide
        jpountz Adrien Grand added a comment -

        Yep, that's fixed!

        Show
        jpountz Adrien Grand added a comment - Yep, that's fixed!

          People

          • Assignee:
            jpountz Adrien Grand
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development