Lucene - Core
  1. Lucene - Core
  2. LUCENE-6929

Multiterm within a SpanNotQuery no longer working

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.4, 6.0
    • Fix Version/s: 5.5, 6.0, 5.4.1
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Some unit tests in LUCENE-5205 that passed in 5.3.1 are now failing with Lucene 5.4.0.

      It looks like MultiTerms are no longer being processed correctly within a SpanNotQuery in 5.4.0 and in trunk.

      1. LUCENE_6929.patch
        4 kB
        Tim Allison
      2. test_case_multi_w_in_spannot.patch
        4 kB
        Tim Allison

        Activity

        Hide
        Tim Allison added a comment - - edited

        Test case for trunk attached. Haven't looked into a solution yet.

        Show
        Tim Allison added a comment - - edited Test case for trunk attached. Haven't looked into a solution yet.
        Hide
        Tim Allison added a comment - - edited

        Looks like pre and post parameters were accidentally dropped when rewriting the SpanNotQuery in r1701621

        Show
        Tim Allison added a comment - - edited Looks like pre and post parameters were accidentally dropped when rewriting the SpanNotQuery in r1701621
        Hide
        Tim Allison added a comment -

        Adrien Grand or David Smiley, any chance you'd be willing to fix this regression in 5.4.0 and trunk?

        Show
        Tim Allison added a comment - Adrien Grand or David Smiley , any chance you'd be willing to fix this regression in 5.4.0 and trunk?
        Hide
        Adrien Grand added a comment -

        Thanks Tim, the patch looks good to me! I'll merge it later today.

        Show
        Adrien Grand added a comment - Thanks Tim, the patch looks good to me! I'll merge it later today.
        Hide
        ASF subversion and git services added a comment -

        Commit 1720365 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1720365 ]

        LUCENE-6929: Fix SpanNotQuery to not ignore the pre/post parameters when rewriting.

        Show
        ASF subversion and git services added a comment - Commit 1720365 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1720365 ] LUCENE-6929 : Fix SpanNotQuery to not ignore the pre/post parameters when rewriting.
        Hide
        ASF subversion and git services added a comment -

        Commit 1720366 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1720366 ]

        LUCENE-6929: Fix SpanNotQuery to not ignore the pre/post parameters when rewriting.

        Show
        ASF subversion and git services added a comment - Commit 1720366 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1720366 ] LUCENE-6929 : Fix SpanNotQuery to not ignore the pre/post parameters when rewriting.
        Hide
        Adrien Grand added a comment -

        I just committed this change to 5.x and trunk. I think that will be a good one to consider backporting to 5.4 as well if/when we decide to do a 5.4.1 release.

        Show
        Adrien Grand added a comment - I just committed this change to 5.x and trunk. I think that will be a good one to consider backporting to 5.4 as well if/when we decide to do a 5.4.1 release.
        Hide
        Tim Allison added a comment -

        Great. +1 to backporting if there's a 5.4.1. Thank you!

        Show
        Tim Allison added a comment - Great. +1 to backporting if there's a 5.4.1. Thank you!
        Hide
        Adrien Grand added a comment -

        Reopened for a 5.4.1 release.

        Show
        Adrien Grand added a comment - Reopened for a 5.4.1 release.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724048 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1724048 ]

        LUCENE-6929: Move CHANGES entry to 5.4.1.

        Show
        ASF subversion and git services added a comment - Commit 1724048 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1724048 ] LUCENE-6929 : Move CHANGES entry to 5.4.1.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724049 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1724049 ]

        LUCENE-6929: Move CHANGES entry to 5.4.1.

        Show
        ASF subversion and git services added a comment - Commit 1724049 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1724049 ] LUCENE-6929 : Move CHANGES entry to 5.4.1.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724051 from Adrien Grand in branch 'dev/branches/lucene_solr_5_4'
        [ https://svn.apache.org/r1724051 ]

        LUCENE-6929: Fix SpanNotQuery to not ignore the pre/post parameters when rewriting.

        Show
        ASF subversion and git services added a comment - Commit 1724051 from Adrien Grand in branch 'dev/branches/lucene_solr_5_4' [ https://svn.apache.org/r1724051 ] LUCENE-6929 : Fix SpanNotQuery to not ignore the pre/post parameters when rewriting.
        Hide
        Tim Allison added a comment -

        Thank you for remembering this one!

        Show
        Tim Allison added a comment - Thank you for remembering this one!
        Hide
        Adrien Grand added a comment -

        You're welcome!

        Show
        Adrien Grand added a comment - You're welcome!

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Tim Allison
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development