Lucene - Core
  1. Lucene - Core
  2. LUCENE-6918

LRUQueryCache.onDocIdSetEviction should not be called when nothing is evicted

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0, 5.4.1
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This method is confusing because it states it will be called "when one or more DocIdSets are removed from this cache" but may actually be called with zero docidsets when evicting a per-segment cache that did not contain any entries.

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch.

        Show
        Adrien Grand added a comment - Here is a patch.
        Hide
        Ryan Ernst added a comment -

        +1, looks good.

        For the changes entry, I think you mean to remove the "not" from "is not only called"?

        Show
        Ryan Ernst added a comment - +1, looks good. For the changes entry, I think you mean to remove the "not" from "is not only called"?
        Hide
        Adrien Grand added a comment -

        Good catch!

        Show
        Adrien Grand added a comment - Good catch!
        Hide
        ASF subversion and git services added a comment -

        Commit 1717947 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1717947 ]

        LUCENE-6918: LRUQueryCache.onDocIdSetEviction is only called when at least one DocIdSet is being evicted. (Adrien Grand)

        Show
        ASF subversion and git services added a comment - Commit 1717947 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1717947 ] LUCENE-6918 : LRUQueryCache.onDocIdSetEviction is only called when at least one DocIdSet is being evicted. (Adrien Grand)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717963 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1717963 ]

        LUCENE-6918: LRUQueryCache.onDocIdSetEviction is only called when at least one DocIdSet is being evicted. (Adrien Grand)

        Show
        ASF subversion and git services added a comment - Commit 1717963 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717963 ] LUCENE-6918 : LRUQueryCache.onDocIdSetEviction is only called when at least one DocIdSet is being evicted. (Adrien Grand)
        Hide
        Adrien Grand added a comment -

        Reopened for a 5.4.1 release.

        Show
        Adrien Grand added a comment - Reopened for a 5.4.1 release.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724044 from Adrien Grand in branch 'dev/branches/lucene_solr_5_4'
        [ https://svn.apache.org/r1724044 ]

        LUCENE-6918: LRUQueryCache.onDocIdSetEviction is only called when at least one DocIdSet is being evicted.

        Show
        ASF subversion and git services added a comment - Commit 1724044 from Adrien Grand in branch 'dev/branches/lucene_solr_5_4' [ https://svn.apache.org/r1724044 ] LUCENE-6918 : LRUQueryCache.onDocIdSetEviction is only called when at least one DocIdSet is being evicted.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724045 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1724045 ]

        LUCENE-6918: Move CHANGES entry to 5.4.1.

        Show
        ASF subversion and git services added a comment - Commit 1724045 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1724045 ] LUCENE-6918 : Move CHANGES entry to 5.4.1.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724046 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1724046 ]

        LUCENE-6918: Move CHANGES entry to 5.4.1.

        Show
        ASF subversion and git services added a comment - Commit 1724046 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1724046 ] LUCENE-6918 : Move CHANGES entry to 5.4.1.

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development