Lucene - Core
  1. Lucene - Core
  2. LUCENE-6911

StandardQueryParser's getMultiFields(CharSequence[] fields) method is a no-op

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      problem summary:

      • lucene.queryparser.flexible.standard.StandardQueryParser.getMultiFields(CharSequence[] fields) is a no-op

      details:

      1. LUCENE-6911.patch
        2 kB
        Christine Poerschke

        Activity

        Hide
        David Smiley added a comment -

        +1 for 5.4. I suggest not even leaving around the deprecated method – looks like it's completely erroneous and nobody would be calling this silly method.

        Show
        David Smiley added a comment - +1 for 5.4. I suggest not even leaving around the deprecated method – looks like it's completely erroneous and nobody would be calling this silly method.
        Hide
        ASF subversion and git services added a comment -

        Commit 1717303 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1717303 ]

        LUCENE-6911: Add correct StandardQueryParser.getMultiFields() method, deprecate no-op StandardQueryParser.getMultiFields(CharSequence[]) method.

        Show
        ASF subversion and git services added a comment - Commit 1717303 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1717303 ] LUCENE-6911 : Add correct StandardQueryParser.getMultiFields() method, deprecate no-op StandardQueryParser.getMultiFields(CharSequence[]) method.
        Hide
        ASF subversion and git services added a comment -

        Commit 1717314 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1717314 ]

        LUCENE-6911: correcting attribution (Mikhail suggested returning getter in LUCENE-6910, thank you)

        Show
        ASF subversion and git services added a comment - Commit 1717314 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1717314 ] LUCENE-6911 : correcting attribution (Mikhail suggested returning getter in LUCENE-6910 , thank you)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717316 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1717316 ]

        LUCENE-6911: Add correct StandardQueryParser.getMultiFields() method, deprecate no-op StandardQueryParser.getMultiFields(CharSequence[]) method. (merge in revision 1717303 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1717316 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717316 ] LUCENE-6911 : Add correct StandardQueryParser.getMultiFields() method, deprecate no-op StandardQueryParser.getMultiFields(CharSequence[]) method. (merge in revision 1717303 from trunk)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717317 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1717317 ]

        LUCENE-6911: correcting attribution (merge in revision 1717314 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1717317 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717317 ] LUCENE-6911 : correcting attribution (merge in revision 1717314 from trunk)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717318 from Christine Poerschke in branch 'dev/branches/lucene_solr_5_4'
        [ https://svn.apache.org/r1717318 ]

        LUCENE-6911: Add correct StandardQueryParser.getMultiFields() method, deprecate no-op StandardQueryParser.getMultiFields(CharSequence[]) method. (merge in revision 1717316 from branch_5x)

        Show
        ASF subversion and git services added a comment - Commit 1717318 from Christine Poerschke in branch 'dev/branches/lucene_solr_5_4' [ https://svn.apache.org/r1717318 ] LUCENE-6911 : Add correct StandardQueryParser.getMultiFields() method, deprecate no-op StandardQueryParser.getMultiFields(CharSequence[]) method. (merge in revision 1717316 from branch_5x)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717319 from Christine Poerschke in branch 'dev/branches/lucene_solr_5_4'
        [ https://svn.apache.org/r1717319 ]

        LUCENE-6911: correcting attribution (merge in revision 1717317 from branch_5x)

        Show
        ASF subversion and git services added a comment - Commit 1717319 from Christine Poerschke in branch 'dev/branches/lucene_solr_5_4' [ https://svn.apache.org/r1717319 ] LUCENE-6911 : correcting attribution (merge in revision 1717317 from branch_5x)
        Hide
        Christine Poerschke added a comment -

        Change committed, deprecating the broken no-op getter.

        How would removal of the deprecated method work, just "remove ... method" instead of "deprecate ... method" in the API Changes section of CHANGES.txt and commit/merge as usual? Or should removal be done only for trunk but not branch_5x?

        Show
        Christine Poerschke added a comment - Change committed, deprecating the broken no-op getter. How would removal of the deprecated method work, just "remove ... method" instead of "deprecate ... method" in the API Changes section of CHANGES.txt and commit/merge as usual? Or should removal be done only for trunk but not branch_5x ?
        Hide
        David Smiley added a comment -

        Since you already backported, I suggest simply removing from trunk. I'm not sure I'd bother with a CHANGES.txt; it was marked deprecated so people can expect it to disappear, not to mention I can't imagine anyone called that before given it's obvious uselessness.

        Show
        David Smiley added a comment - Since you already backported, I suggest simply removing from trunk. I'm not sure I'd bother with a CHANGES.txt; it was marked deprecated so people can expect it to disappear, not to mention I can't imagine anyone called that before given it's obvious uselessness.
        Hide
        ASF subversion and git services added a comment -

        Commit 1717396 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1717396 ]

        LUCENE-6911: remove deprecated, no-op StandardQueryParser.getMultiFields(CharSequence[] fields) method.

        Show
        ASF subversion and git services added a comment - Commit 1717396 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1717396 ] LUCENE-6911 : remove deprecated, no-op StandardQueryParser.getMultiFields(CharSequence[] fields) method.
        Hide
        Christine Poerschke added a comment -

        Done. Yes, someone calling the no-op method seems unlikely. Was just trying to get a sense of how deprecating and removal of methods works generally. Thanks for the guidance.

        Show
        Christine Poerschke added a comment - Done. Yes, someone calling the no-op method seems unlikely. Was just trying to get a sense of how deprecating and removal of methods works generally. Thanks for the guidance.
        Hide
        Christine Poerschke added a comment -

        Mikhail Khludnev and David Smiley - thanks for your input on LUCENE-6910 and this ticket LUCENE-6911 here.
        Rishabh Patel - thanks for running the Coverity Scan analysis and sharing the findings on the dev mailing list.

        Show
        Christine Poerschke added a comment - Mikhail Khludnev and David Smiley - thanks for your input on LUCENE-6910 and this ticket LUCENE-6911 here. Rishabh Patel - thanks for running the Coverity Scan analysis and sharing the findings on the dev mailing list.

          People

          • Assignee:
            Christine Poerschke
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development