Lucene - Core
  1. Lucene - Core
  2. LUCENE-6910

fix 2 interesting and 2 trivial issues found by "Coverity scan results of Lucene"

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0, 5.4.1
    • Component/s: None
    • Labels:
      None

      Description

      https://scan.coverity.com/projects/5620 mentioned on the dev mailing list (http://mail-archives.apache.org/mod_mbox/lucene-dev/201507.mbox/%3cCAFTwexg51-jm_6MDEoz1rEagN3xgkBeTOz5OU_f+mELbOO1POw@mail.gmail.com%3e) in July 2015:

      • coverity CID 119973
      • coverity CID 120040
      • coverity CID 120081
      • coverity CID 120628
      1. LUCENE-6910.patch
        4 kB
        Christine Poerschke
      2. LUCENE-6910.patch
        4 kB
        Christine Poerschke

        Activity

        Hide
        Mikhail Khludnev added a comment -

        patch seems fine, but the last chunk scares me much. as far as I get, nobody use it, it should be a getter like

          public CharSequence[] getMultiFields() {
            return getQueryConfigHandler().get(ConfigurationKeys.MULTI_FIELDS);
          }
        

        formally it's non-compatible change, but it think it's worth to break it even in 5.4, as an alternative let's fix it in trunk only.

        Show
        Mikhail Khludnev added a comment - patch seems fine, but the last chunk scares me much. as far as I get, nobody use it, it should be a getter like public CharSequence[] getMultiFields() { return getQueryConfigHandler().get(ConfigurationKeys.MULTI_FIELDS); } formally it's non-compatible change, but it think it's worth to break it even in 5.4, as an alternative let's fix it in trunk only.
        Hide
        Christine Poerschke added a comment -

        Thanks Mikhail. I have created LUCENE-6911 to deal with StandardQueryParser.getMultiFields separately for clarity. Perhaps for 5.4 the broken method could be left as-is and marked as deprecated and in trunk we remove the broken method?

        Show
        Christine Poerschke added a comment - Thanks Mikhail. I have created LUCENE-6911 to deal with StandardQueryParser.getMultiFields separately for clarity. Perhaps for 5.4 the broken method could be left as-is and marked as deprecated and in trunk we remove the broken method?
        Hide
        Christine Poerschke added a comment -

        Removing last chunk (LUCENE-6911 to deal with it separately).

        Show
        Christine Poerschke added a comment - Removing last chunk ( LUCENE-6911 to deal with it separately).
        Hide
        ASF subversion and git services added a comment -

        Commit 1717314 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1717314 ]

        LUCENE-6911: correcting attribution (Mikhail suggested returning getter in LUCENE-6910, thank you)

        Show
        ASF subversion and git services added a comment - Commit 1717314 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1717314 ] LUCENE-6911 : correcting attribution (Mikhail suggested returning getter in LUCENE-6910 , thank you)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717756 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1717756 ]

        LUCENE-6910: remove line.length(); statement in TrecContentSource.java (https://scan.coverity.com/projects/5620 CID 120628)

        Show
        ASF subversion and git services added a comment - Commit 1717756 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1717756 ] LUCENE-6910 : remove line.length(); statement in TrecContentSource.java ( https://scan.coverity.com/projects/5620 CID 120628)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717772 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1717772 ]

        LUCENE-6910: remove line.length(); statement in TrecContentSource.java (https://scan.coverity.com/projects/5620 CID 120628) (merge in revision 1717756 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1717772 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717772 ] LUCENE-6910 : remove line.length(); statement in TrecContentSource.java ( https://scan.coverity.com/projects/5620 CID 120628) (merge in revision 1717756 from trunk)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717804 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1717804 ]

        LUCENE-6910: remove no-op code in CheckIndex.java (https://scan.coverity.com/projects/5620 CID 120040)

        Show
        ASF subversion and git services added a comment - Commit 1717804 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1717804 ] LUCENE-6910 : remove no-op code in CheckIndex.java ( https://scan.coverity.com/projects/5620 CID 120040)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717820 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1717820 ]

        LUCENE-6910: remove no-op code in CheckIndex.java (https://scan.coverity.com/projects/5620 CID 120040) (merge in revision 1717804 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1717820 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1717820 ] LUCENE-6910 : remove no-op code in CheckIndex.java ( https://scan.coverity.com/projects/5620 CID 120040) (merge in revision 1717804 from trunk)
        Hide
        ASF subversion and git services added a comment -

        Commit 1717993 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1717993 ]

        LUCENE-6910: fix 'if ... > Integer.MAX_VALUE' check in (Binary|Numeric)DocValuesFieldUpdates.merge (https://scan.coverity.com/projects/5620 CID 119973 and CID 120081)

        Show
        ASF subversion and git services added a comment - Commit 1717993 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1717993 ] LUCENE-6910 : fix 'if ... > Integer.MAX_VALUE' check in (Binary|Numeric)DocValuesFieldUpdates.merge ( https://scan.coverity.com/projects/5620 CID 119973 and CID 120081)
        Hide
        ASF subversion and git services added a comment -

        Commit 1718007 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1718007 ]

        LUCENE-6910: fix 'if ... > Integer.MAX_VALUE' check in (Binary|Numeric)DocValuesFieldUpdates.merge (https://scan.coverity.com/projects/5620 CID 119973 and CID 120081) (merge in revision 1717993 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1718007 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1718007 ] LUCENE-6910 : fix 'if ... > Integer.MAX_VALUE' check in (Binary|Numeric)DocValuesFieldUpdates.merge ( https://scan.coverity.com/projects/5620 CID 119973 and CID 120081) (merge in revision 1717993 from trunk)
        Hide
        Adrien Grand added a comment -

        Reopened for a 5.4.1 release.

        Show
        Adrien Grand added a comment - Reopened for a 5.4.1 release.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724053 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1724053 ]

        LUCENE-6910: Move CHANGES entry to 5.4.1.

        Show
        ASF subversion and git services added a comment - Commit 1724053 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1724053 ] LUCENE-6910 : Move CHANGES entry to 5.4.1.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724054 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1724054 ]

        LUCENE-6910: Move CHANGES entry to 5.4.1.

        Show
        ASF subversion and git services added a comment - Commit 1724054 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1724054 ] LUCENE-6910 : Move CHANGES entry to 5.4.1.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724055 from Adrien Grand in branch 'dev/branches/lucene_solr_5_4'
        [ https://svn.apache.org/r1724055 ]

        LUCENE-6910: fix 'if ... > Integer.MAX_VALUE' check in (Binary|Numeric)DocValuesFieldUpdates.merge (https://scan.coverity.com/projects/5620 CID 119973 and CID 120081)

        Show
        ASF subversion and git services added a comment - Commit 1724055 from Adrien Grand in branch 'dev/branches/lucene_solr_5_4' [ https://svn.apache.org/r1724055 ] LUCENE-6910 : fix 'if ... > Integer.MAX_VALUE' check in (Binary|Numeric)DocValuesFieldUpdates.merge ( https://scan.coverity.com/projects/5620 CID 119973 and CID 120081)

          People

          • Assignee:
            Christine Poerschke
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development