Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6900

Grouping sortWithinGroup should use Sort.RELEVANCE to indicate that, not null

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5
    • Component/s: modules/grouping
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      In AbstractSecondPassGroupingCollector, withinGroupSort uses a value of null to indicate a relevance sort. I think it's nicer to use Sort.RELEVANCE for this – after all it's how the groupSort variable is handled. This choice is also seen in GroupingSearch; likely some other collaborators too.

      Martijn van Groningen is there some wisdom in the current choice that escapes me? If not I'll post a patch.

        Attachments

        1. LUCENE_6900.patch
          32 kB
          David Smiley
        2. LUCENE_6900.patch
          33 kB
          David Smiley

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: