Lucene - Core
  1. Lucene - Core
  2. LUCENE-6887

5x: backport ClassicSimilarity, mark DefaultSimilarity deprecated & update javadocs to mention ClassicSim vs. BM25Sim

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      LUCENE-6789 changed the default Similarity on trunk to BM25, and renamed DefaultSimiliarity to ClassicSimilarity for backcompat w/o confusion about the "default" name.

      But nothing related to this change was committed to the 5x branch.

      On the 5x branch we should:

      • mark DefaultSimiliarity deprecated
      • provide a ClassicSimilarity for 5.x users to switch to to resolve deprecations w/o changing behavior (and allow smooth upgrade to 6.x later)
      • note in the DefaultSimiliarity javadocs that starting with 6.0 BM25 will be the recommended default and users should investigate it

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          patch for 5x branch with changes (generated using svn diff --git to preserve the file copy info)

          Show
          Hoss Man added a comment - patch for 5x branch with changes (generated using svn diff --git to preserve the file copy info)
          Hide
          ASF subversion and git services added a comment -

          Commit 1712868 from hossman@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1712868 ]

          LUCENE-6887: DefaultSimilarity is deprecated, use ClassicSimilarity for equivilent behavior, or consider switching to BM25Similarity which will become the new default in Lucene 6.0

          Show
          ASF subversion and git services added a comment - Commit 1712868 from hossman@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1712868 ] LUCENE-6887 : DefaultSimilarity is deprecated, use ClassicSimilarity for equivilent behavior, or consider switching to BM25Similarity which will become the new default in Lucene 6.0
          Hide
          ASF subversion and git services added a comment -

          Commit 1712869 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1712869 ]

          LUCENE-6887: 5.4 CHANGES entry to backport (see branch_5x r1712868)

          Show
          ASF subversion and git services added a comment - Commit 1712869 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1712869 ] LUCENE-6887 : 5.4 CHANGES entry to backport (see branch_5x r1712868)
          Hide
          ASF subversion and git services added a comment -

          Commit 1712870 from hossman@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1712870 ]

          LUCENE-6887: 5.4 CHANGES entry (backport r1712869)

          Show
          ASF subversion and git services added a comment - Commit 1712870 from hossman@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1712870 ] LUCENE-6887 : 5.4 CHANGES entry (backport r1712869)

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development