Lucene - Core
  1. Lucene - Core
  2. LUCENE-6872

IndexWriter OOM handling should be any VirtualMachineError

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      IndexWriter is defensive in this case: this error could come from any unexpected place.

      But its superclass VirtualMachineError is the correct one: "Thrown to indicate that the Java Virtual Machine is broken or has run out of resources necessary for it to continue operating."

        Activity

        Hide
        Robert Muir added a comment -

        patch: I renamed the test and added a second test method testing another subclass.

        Show
        Robert Muir added a comment - patch: I renamed the test and added a second test method testing another subclass.
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Uwe Schindler added a comment -

        +1

        Show
        Uwe Schindler added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1712310 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1712310 ]

        LUCENE-6872: IndexWriter OOM handling should be any VirtualMachineError

        Show
        ASF subversion and git services added a comment - Commit 1712310 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1712310 ] LUCENE-6872 : IndexWriter OOM handling should be any VirtualMachineError
        Hide
        ASF subversion and git services added a comment -

        Commit 1712314 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1712314 ]

        LUCENE-6872: IndexWriter OOM handling should be any VirtualMachineError

        Show
        ASF subversion and git services added a comment - Commit 1712314 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1712314 ] LUCENE-6872 : IndexWriter OOM handling should be any VirtualMachineError
        Hide
        Mike Drob added a comment -

        Should we modify the checks in SolrIndexWriter, DirectUpdateHandler2, and other solr pieces to also replace OOME with VME? Can do that in a solr JIRA, I suppose.

        Show
        Mike Drob added a comment - Should we modify the checks in SolrIndexWriter, DirectUpdateHandler2, and other solr pieces to also replace OOME with VME? Can do that in a solr JIRA, I suppose.
        Hide
        Mark Miller added a comment -

        It's really different cases I think. This is about IndexWriter handing unrecoverable errors properly. Solr's interest in OOMExceptions is about them bubbling up to the JVM so that you can run a script on the first one that does. That only works with OOMException, not other VirtualMachineErrors.

        Show
        Mark Miller added a comment - It's really different cases I think. This is about IndexWriter handing unrecoverable errors properly. Solr's interest in OOMExceptions is about them bubbling up to the JVM so that you can run a script on the first one that does. That only works with OOMException, not other VirtualMachineErrors.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development