Lucene - Core
  1. Lucene - Core
  2. LUCENE-6862

Upgrade of RandomizedRunner to version 2.2.0

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Issue Links

        Activity

        Hide
        Dawid Weiss added a comment -

        Patch, spatial4j uses a dependency (spatial4j-0.5-tests.jar) that in turn seems to be referencing methods from another version of RandomizedTest – can't commit because the build currently breaks with no such method. David Smiley could you take a look?

          2> NOTE: reproduce with: ant test  -Dtestcase=Geo3dShapeSphereModelRectRelationTest -Dtests.method=testGeoBBoxRect -Dtests.seed=54887386AAEC5BEF -Dtests.slow=true -Dtests.locale=fi -Dtests.timezone=Pacific/Pitcairn -Dtests.asserts=true -Dtests.file.encoding=UTF-8
        [19:19:25.647] ERROR   0.04s J1 | Geo3dShapeSphereModelRectRelationTest.testGeoBBoxRect <<<
           > Throwable #1: java.lang.NoSuchMethodError: com.spatial4j.core.shape.RandomizedShapeTest.assertEquals(Ljava/lang/Object;Ljava/lang/Object;)V
           > 	at __randomizedtesting.SeedInfo.seed([54887386AAEC5BEF:702DDBBE8EDF25B1]:0)
           > 	at com.spatial4j.core.shape.RandomizedShapeTest.randomPointIn(RandomizedShapeTest.java:257)
        
        Show
        Dawid Weiss added a comment - Patch, spatial4j uses a dependency (spatial4j-0.5-tests.jar) that in turn seems to be referencing methods from another version of RandomizedTest – can't commit because the build currently breaks with no such method. David Smiley could you take a look? 2> NOTE: reproduce with: ant test -Dtestcase=Geo3dShapeSphereModelRectRelationTest -Dtests.method=testGeoBBoxRect -Dtests.seed=54887386AAEC5BEF -Dtests.slow= true -Dtests.locale=fi -Dtests.timezone=Pacific/Pitcairn -Dtests.asserts= true -Dtests.file.encoding=UTF-8 [19:19:25.647] ERROR 0.04s J1 | Geo3dShapeSphereModelRectRelationTest.testGeoBBoxRect <<< > Throwable #1: java.lang.NoSuchMethodError: com.spatial4j.core.shape.RandomizedShapeTest.assertEquals(Ljava/lang/ Object ;Ljava/lang/ Object ;)V > at __randomizedtesting.SeedInfo.seed([54887386AAEC5BEF:702DDBBE8EDF25B1]:0) > at com.spatial4j.core.shape.RandomizedShapeTest.randomPointIn(RandomizedShapeTest.java:257)
        Hide
        David Smiley added a comment -

        Thorny issue. Geo3dShape (in Lucene spatial) implements Shape (a Spatial4j interface), and I've always thought it ideally would exist and be provided by Spatial4j, and thus be tested there too. This is the only bit of integration there right now. It's been on my todo list. I think I vote to mark these tests as @Ignore for now, but Geo3dRptTest can stay as it's not impacted and fundamentally is a Lucene (spatial) thing. Feel free to do so with a comment, obviously.

        Show
        David Smiley added a comment - Thorny issue. Geo3dShape (in Lucene spatial) implements Shape (a Spatial4j interface), and I've always thought it ideally would exist and be provided by Spatial4j, and thus be tested there too. This is the only bit of integration there right now. It's been on my todo list. I think I vote to mark these tests as @Ignore for now, but Geo3dRptTest can stay as it's not impacted and fundamentally is a Lucene (spatial) thing. Feel free to do so with a comment, obviously.
        Hide
        Dawid Weiss added a comment -

        I can wait until you upgrade RR in spatial4j – not a problem with me. Unless it's going to take a long time, in which case I can mark those offending tests as ignored.

        Show
        Dawid Weiss added a comment - I can wait until you upgrade RR in spatial4j – not a problem with me. Unless it's going to take a long time, in which case I can mark those offending tests as ignored.
        Hide
        David Smiley added a comment -

        I suggest marking them as ignored – all the more motivation for me to get on with moving Geo3dShape to Spatial4j.

        Show
        David Smiley added a comment - I suggest marking them as ignored – all the more motivation for me to get on with moving Geo3dShape to Spatial4j.
        Hide
        ASF subversion and git services added a comment -

        Commit 1711203 from Dawid Weiss in branch 'dev/trunk'
        [ https://svn.apache.org/r1711203 ]

        LUCENE-6862: Upgrade of RandomizedRunner to version 2.2.0

        Show
        ASF subversion and git services added a comment - Commit 1711203 from Dawid Weiss in branch 'dev/trunk' [ https://svn.apache.org/r1711203 ] LUCENE-6862 : Upgrade of RandomizedRunner to version 2.2.0
        Hide
        ASF subversion and git services added a comment -

        Commit 1711205 from Dawid Weiss in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1711205 ]

        LUCENE-6862: Upgrade of RandomizedRunner to version 2.2.0

        Show
        ASF subversion and git services added a comment - Commit 1711205 from Dawid Weiss in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1711205 ] LUCENE-6862 : Upgrade of RandomizedRunner to version 2.2.0

          People

          • Assignee:
            Dawid Weiss
            Reporter:
            Dawid Weiss
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development