Lucene - Core
  1. Lucene - Core
  2. LUCENE-6858

Fix ContextSuggestField to correctly wrap token stream

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.4, 6.0
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Currently, when a ContextSuggestField is analyzed with a completion analyzer, it incorrectly uses the completion token stream as an input to it's PrefixTokenFilter instead of using the underlying token stream, before wrapping the token stream as a completion token stream.

      1. LUCENE-6858.patch
        25 kB
        Areek Zillur

        Activity

        Hide
        Areek Zillur added a comment -

        Initial patch:

        • correctly wrap incoming completion token stream in ContextSuggestField
        • added tests
        • minor: increase topN size for nrt suggester to ensure search admissibility in case of suggestions with multiple contexts.
        Show
        Areek Zillur added a comment - Initial patch: correctly wrap incoming completion token stream in ContextSuggestField added tests minor: increase topN size for nrt suggester to ensure search admissibility in case of suggestions with multiple contexts.
        Hide
        Michael McCandless added a comment -

        +1, thanks Areek Zillur.

        Show
        Michael McCandless added a comment - +1, thanks Areek Zillur .
        Hide
        ASF subversion and git services added a comment -

        Commit 1711158 from Areek Zillur in branch 'dev/trunk'
        [ https://svn.apache.org/r1711158 ]

        LUCENE-6858: Fix ContextSuggestField to correctly wrap token stream when using CompletionAnalyzer

        Show
        ASF subversion and git services added a comment - Commit 1711158 from Areek Zillur in branch 'dev/trunk' [ https://svn.apache.org/r1711158 ] LUCENE-6858 : Fix ContextSuggestField to correctly wrap token stream when using CompletionAnalyzer
        Hide
        ASF subversion and git services added a comment -

        Commit 1711159 from Areek Zillur in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1711159 ]

        LUCENE-6858: Fix ContextSuggestField to correctly wrap token stream when using CompletionAnalyzer

        Show
        ASF subversion and git services added a comment - Commit 1711159 from Areek Zillur in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1711159 ] LUCENE-6858 : Fix ContextSuggestField to correctly wrap token stream when using CompletionAnalyzer
        Hide
        Areek Zillur added a comment -
        Show
        Areek Zillur added a comment - Thanks Michael McCandless !

          People

          • Assignee:
            Areek Zillur
            Reporter:
            Areek Zillur
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development