Lucene - Core
  1. Lucene - Core
  2. LUCENE-6856

LRUQueryCache.CachingWrapperWeight should delegate the bulk scorer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I think we have two issues with LRUQueryCache.CachingWrapperWeight:

      • when generating cached entries, it creates a Scorer and loads it into a DocIdSet while it would be more efficient to use a BulkScorer to do so since we consume all matching documents
      • when a query should not be cached (eg. because it has not be seen often enough yet), we do not delegate the bulk scorer, which means that we will use a DefaultBulkScorer on top of the scorer, which can be significantly slower for some queries (eg. disjunctions)

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch.

        Show
        Adrien Grand added a comment - Here is a patch.
        Hide
        ASF subversion and git services added a comment -

        Commit 1710832 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1710832 ]

        LUCENE-6856: LRUQueryCache.CachingWrapperWeight should delegate the bulk scorer.

        Show
        ASF subversion and git services added a comment - Commit 1710832 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1710832 ] LUCENE-6856 : LRUQueryCache.CachingWrapperWeight should delegate the bulk scorer.
        Hide
        ASF subversion and git services added a comment -

        Commit 1710833 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1710833 ]

        LUCENE-6856: LRUQueryCache.CachingWrapperWeight should delegate the bulk scorer.

        Show
        ASF subversion and git services added a comment - Commit 1710833 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1710833 ] LUCENE-6856 : LRUQueryCache.CachingWrapperWeight should delegate the bulk scorer.

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development