Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: modules/expressions
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Simple upgrade to ANTLR 4.5.1 which includes numerous bug fixes:
      https://github.com/antlr/antlr4/releases/tag/4.5.1

      Note this does not change the grammar itself, only small pieces of the generated code.

      1. LUCENE-6830.patch
        5 kB
        Uwe Schindler
      2. LUCENE-6830.patch
        3 kB
        Jack Conradson

        Activity

        Hide
        Jack Conradson added a comment -

        Patch attached.

        Show
        Jack Conradson added a comment - Patch attached.
        Hide
        Uwe Schindler added a comment -

        Hi Jack, thanks for the update.

        My question: You only updated the antlr code generator but not the runtime. Is this intended?

        Show
        Uwe Schindler added a comment - Hi Jack, thanks for the update. My question: You only updated the antlr code generator but not the runtime. Is this intended?
        Hide
        Uwe Schindler added a comment -

        Attached is a new patch that also updates the runtime. All tests pass.

        Show
        Uwe Schindler added a comment - Attached is a new patch that also updates the runtime. All tests pass.
        Hide
        Jack Conradson added a comment -

        Oops! Not updating the runtime was a mistake on my part, thank you for taking the time to fix that.

        Show
        Jack Conradson added a comment - Oops! Not updating the runtime was a mistake on my part, thank you for taking the time to fix that.
        Hide
        ASF subversion and git services added a comment -

        Commit 1708935 from Uwe Schindler in branch 'dev/trunk'
        [ https://svn.apache.org/r1708935 ]

        LUCENE-6830: Upgrade ANTLR used in expressions module to version 4.5.1-1

        Show
        ASF subversion and git services added a comment - Commit 1708935 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1708935 ] LUCENE-6830 : Upgrade ANTLR used in expressions module to version 4.5.1-1
        Hide
        ASF subversion and git services added a comment -

        Commit 1708936 from Uwe Schindler in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1708936 ]

        Merged revision(s) 1708935 from lucene/dev/trunk:
        LUCENE-6830: Upgrade ANTLR used in expressions module to version 4.5.1-1

        Show
        ASF subversion and git services added a comment - Commit 1708936 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1708936 ] Merged revision(s) 1708935 from lucene/dev/trunk: LUCENE-6830 : Upgrade ANTLR used in expressions module to version 4.5.1-1
        Hide
        ASF subversion and git services added a comment -

        Commit 1708980 from Uwe Schindler in branch 'dev/trunk'
        [ https://svn.apache.org/r1708980 ]

        LUCENE-6830: fix eol-style

        Show
        ASF subversion and git services added a comment - Commit 1708980 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1708980 ] LUCENE-6830 : fix eol-style
        Hide
        ASF subversion and git services added a comment -

        Commit 1708981 from Uwe Schindler in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1708981 ]

        Merged revision(s) 1708980 from lucene/dev/trunk:
        LUCENE-6830: fix eol-style

        Show
        ASF subversion and git services added a comment - Commit 1708981 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1708981 ] Merged revision(s) 1708980 from lucene/dev/trunk: LUCENE-6830 : fix eol-style
        Hide
        Uwe Schindler added a comment -

        Sorry for the Jenkins failure. Thanks Jack for upgrading!

        Show
        Uwe Schindler added a comment - Sorry for the Jenkins failure. Thanks Jack for upgrading!

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Jack Conradson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development