Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4
    • Component/s: modules/spatial
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spatial4j 0.5 was released a few days ago. There are some bug fixes, most of which were surfaced via the tests here. It also publishes the test jar (thanks Nicholas Knize for that one) and with that there are a couple test utilities here I can remove.

      https://github.com/locationtech/spatial4j/blob/master/CHANGES.md

        Issue Links

          Activity

          Hide
          David Smiley added a comment -

          Here's the patch.

          The additional method Shape.getContext() that needs to be implemented accounted for the only non-test change.

          Show
          David Smiley added a comment - Here's the patch. The additional method Shape.getContext() that needs to be implemented accounted for the only non-test change.
          Hide
          ASF subversion and git services added a comment -

          Commit 1704759 from David Smiley in branch 'dev/trunk'
          [ https://svn.apache.org/r1704759 ]

          LUCENE-6810: Spatial4j 0.5 upgrade. Mostly fixes a few edge-case bugs.

          • the spatial4j tests jar is published and we use some utilities there; this adds a test dependency on it & SLF4J.
          Show
          ASF subversion and git services added a comment - Commit 1704759 from David Smiley in branch 'dev/trunk' [ https://svn.apache.org/r1704759 ] LUCENE-6810 : Spatial4j 0.5 upgrade. Mostly fixes a few edge-case bugs. the spatial4j tests jar is published and we use some utilities there; this adds a test dependency on it & SLF4J.
          Hide
          ASF subversion and git services added a comment -

          Commit 1704760 from David Smiley in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1704760 ]

          LUCENE-6810: Spatial4j 0.5 upgrade. Mostly fixes a few edge-case bugs.

          • the spatial4j tests jar is published and we use some utilities there; this adds a test dependency on it & SLF4J.
          Show
          ASF subversion and git services added a comment - Commit 1704760 from David Smiley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1704760 ] LUCENE-6810 : Spatial4j 0.5 upgrade. Mostly fixes a few edge-case bugs. the spatial4j tests jar is published and we use some utilities there; this adds a test dependency on it & SLF4J.
          Hide
          Michael McCandless added a comment -

          Builds seem to be broken from this commit ... looks like Solr's .sha1 files need upgrading too?

          BUILD FAILED
          /Users/jenkins/workspace/Lucene-Solr-5.x-MacOSX/build.xml:785: The following error occurred while executing this line:
          /Users/jenkins/workspace/Lucene-Solr-5.x-MacOSX/build.xml:665: The following error occurred while executing this line:
          /Users/jenkins/workspace/Lucene-Solr-5.x-MacOSX/build.xml:652: Source checkout is dirty after running tests!!! Offending files:
          * ./solr/licenses/spatial4j-0.4.1.jar.sha1
          
          Show
          Michael McCandless added a comment - Builds seem to be broken from this commit ... looks like Solr's .sha1 files need upgrading too? BUILD FAILED /Users/jenkins/workspace/Lucene-Solr-5.x-MacOSX/build.xml:785: The following error occurred while executing this line: /Users/jenkins/workspace/Lucene-Solr-5.x-MacOSX/build.xml:665: The following error occurred while executing this line: /Users/jenkins/workspace/Lucene-Solr-5.x-MacOSX/build.xml:652: Source checkout is dirty after running tests!!! Offending files: * ./solr/licenses/spatial4j-0.4.1.jar.sha1
          Hide
          David Smiley added a comment -

          ouch; thanks for bringing this to my attention! I’m traveling today but I
          will have time to get to it at some point today if I’m not beaten to it.

          On Wed, Sep 23, 2015 at 3:21 PM Michael McCandless (JIRA) <jira@apache.org>


          Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
          LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
          http://www.solrenterprisesearchserver.com

          Show
          David Smiley added a comment - ouch; thanks for bringing this to my attention! I’m traveling today but I will have time to get to it at some point today if I’m not beaten to it. On Wed, Sep 23, 2015 at 3:21 PM Michael McCandless (JIRA) <jira@apache.org> – Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
          Hide
          Anshum Gupta added a comment -

          Seems like we just need to remove that file. spatial4j-0.5.jar.sha1 already exists in Solr.
          I'll delete and commit.

          Show
          Anshum Gupta added a comment - Seems like we just need to remove that file. spatial4j-0.5.jar.sha1 already exists in Solr. I'll delete and commit.
          Hide
          ASF subversion and git services added a comment -

          Commit 1704969 from Anshum Gupta in branch 'dev/trunk'
          [ https://svn.apache.org/r1704969 ]

          LUCENE-6810: Removing spatial4j-0.4.1.jar.sha1 from Solr

          Show
          ASF subversion and git services added a comment - Commit 1704969 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1704969 ] LUCENE-6810 : Removing spatial4j-0.4.1.jar.sha1 from Solr
          Hide
          ASF subversion and git services added a comment -

          Commit 1704970 from Anshum Gupta in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1704970 ]

          LUCENE-6810: Removing spatial4j-0.4.1.jar.sha1 from Solr (merge from trunk)

          Show
          ASF subversion and git services added a comment - Commit 1704970 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1704970 ] LUCENE-6810 : Removing spatial4j-0.4.1.jar.sha1 from Solr (merge from trunk)
          Hide
          ASF subversion and git services added a comment -

          Commit 1711010 from David Smiley in branch 'dev/trunk'
          [ https://svn.apache.org/r1711010 ]

          LUCENE-6860: LUCENE-6810: Fix spatial dependency on spatial4j-tests to be a test dependency!

          Show
          ASF subversion and git services added a comment - Commit 1711010 from David Smiley in branch 'dev/trunk' [ https://svn.apache.org/r1711010 ] LUCENE-6860 : LUCENE-6810 : Fix spatial dependency on spatial4j-tests to be a test dependency!
          Hide
          ASF subversion and git services added a comment -

          Commit 1711011 from David Smiley in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1711011 ]

          LUCENE-6860: LUCENE-6810: Fix spatial dependency on spatial4j-tests to be a test dependency!

          Show
          ASF subversion and git services added a comment - Commit 1711011 from David Smiley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1711011 ] LUCENE-6860 : LUCENE-6810 : Fix spatial dependency on spatial4j-tests to be a test dependency!

            People

            • Assignee:
              David Smiley
              Reporter:
              David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development