Lucene - Core
  1. Lucene - Core
  2. LUCENE-6800

Regularize how Geo3d XYZSolids are managed, as was done for GeoCircle

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: modules/spatial
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The instantiation of XYZSolid-family objects is currently done through a factory method in GeoAreaFactory. For consistency, there should be the following:

      • underlying interface called XYZSolid, which extends GeoArea
      • a XYZSolidFactory factory class, that instantiates XYZSolid objects
      • reference to XYZSolidFactory.makeXYZSolid() from within GeoAreaFactory

        Activity

        Hide
        Karl Wright added a comment -

        Michael McCandless: Patch addressing this last known structural issue with geo3d.

        Show
        Karl Wright added a comment - Michael McCandless : Patch addressing this last known structural issue with geo3d.
        Hide
        Michael McCandless added a comment -

        Thanks Karl Wright, looks good, I'll commit shortly.

        Show
        Michael McCandless added a comment - Thanks Karl Wright , looks good, I'll commit shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1702454 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1702454 ]

        LUCENE-6800: use factory to create XYZSolid

        Show
        ASF subversion and git services added a comment - Commit 1702454 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1702454 ] LUCENE-6800 : use factory to create XYZSolid
        Hide
        ASF subversion and git services added a comment -

        Commit 1702455 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1702455 ]

        LUCENE-6800: use factory to create XYZSolid

        Show
        ASF subversion and git services added a comment - Commit 1702455 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1702455 ] LUCENE-6800 : use factory to create XYZSolid

          People

          • Assignee:
            Unassigned
            Reporter:
            Karl Wright
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development