Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6786

Remove IndexFileDeleter.refresh(String)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today IW has try/finally around places (flush, merge) that write
      per-segment files and on exception uses IFD.refresh(String) to remove
      any newly created but now unreferenced files.

      But, since merge exceptions are now tragic, and IFD.refresh() (not
      taking a segment name) will be called, doing the same thing, I think
      it's safe to remove the per-segment refresh.

      This makes IW a little bit simpler ... and it means at least one fewer Directory.listAll while handling merge exceptions.

        Attachments

        1. LUCENE-6786.patch
          6 kB
          Michael McCandless

          Activity

            People

            • Assignee:
              mikemccand Michael McCandless
              Reporter:
              mikemccand Michael McCandless
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: