Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      LUCENE-6585 started the work to flatten nested conjunctions, but this only works with approximations. Otherwise a ConjunctionScorer is passed to ConjunctionDISI.intersect, and is not flattened since it is not an instance of ConjunctionDISI.

      1. LUCENE-6773.patch
        5 kB
        Adrien Grand
      2. LUCENE-6773.patch
        2 kB
        Adrien Grand

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch.

        Show
        Adrien Grand added a comment - Here is a patch.
        Hide
        Ryan Ernst added a comment -

        +1

        Can you add a test to TestConjunctionDISI?

        Show
        Ryan Ernst added a comment - +1 Can you add a test to TestConjunctionDISI?
        Hide
        Adrien Grand added a comment -

        Thanks Ryan for having a look. Here is an updated patch.

        Show
        Adrien Grand added a comment - Thanks Ryan for having a look. Here is an updated patch.
        Hide
        Ryan Ernst added a comment -

        Test looks good, thanks!

        Show
        Ryan Ernst added a comment - Test looks good, thanks!
        Hide
        ASF subversion and git services added a comment -

        Commit 1701949 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1701949 ]

        LUCENE-6773: Inline ConjunctionScorer into ConjunctionDISI.

        Show
        ASF subversion and git services added a comment - Commit 1701949 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1701949 ] LUCENE-6773 : Inline ConjunctionScorer into ConjunctionDISI.
        Hide
        ASF subversion and git services added a comment -

        Commit 1701963 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1701963 ]

        LUCENE-6773: Inline ConjunctionScorer into ConjunctionDISI.

        Show
        ASF subversion and git services added a comment - Commit 1701963 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1701963 ] LUCENE-6773 : Inline ConjunctionScorer into ConjunctionDISI.

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development