Lucene - Core
  1. Lucene - Core
  2. LUCENE-6768

AbstractFirstPassGroupingCollector.groupSort private member is not needed

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      patch with proposed change to follow.

      (SOLR-2072 could result in AbstractFirstPassGroupingCollector changes also but from glancing through the patches the groupSort member would still not be needed (but could of course be added back if/when needed))

      1. LUCENE-6768.patch
        1 kB
        Christine Poerschke
      2. LUCENE-6768.patch
        2 kB
        Christine Poerschke

        Activity

        Hide
        Christine Poerschke added a comment -

        attaching patch against trunk

        Show
        Christine Poerschke added a comment - attaching patch against trunk
        Hide
        Michael McCandless added a comment -

        +1, except can we keep the local var sortFieldCount just set it to e.g. comparators.length instead of the confusing compIDXEnd+1?

        Show
        Michael McCandless added a comment - +1, except can we keep the local var sortFieldCount just set it to e.g. comparators.length instead of the confusing compIDXEnd+1 ?
        Hide
        Christine Poerschke added a comment -

        attaching alternative patch against trunk

        Show
        Christine Poerschke added a comment - attaching alternative patch against trunk
        Hide
        Michael McCandless added a comment -

        +1, thank you Christine Poerschke!

        Show
        Michael McCandless added a comment - +1, thank you Christine Poerschke !
        Hide
        ASF subversion and git services added a comment -

        Commit 1698418 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1698418 ]

        LUCENE-6768: AbstractFirstPassGroupingCollector.groupSort private member is not needed.

        Show
        ASF subversion and git services added a comment - Commit 1698418 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1698418 ] LUCENE-6768 : AbstractFirstPassGroupingCollector.groupSort private member is not needed.
        Hide
        ASF subversion and git services added a comment -

        Commit 1698422 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1698422 ]

        LUCENE-6768: AbstractFirstPassGroupingCollector.groupSort private member is not needed. (merge in revision 1698418 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1698422 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1698422 ] LUCENE-6768 : AbstractFirstPassGroupingCollector.groupSort private member is not needed. (merge in revision 1698418 from trunk)

          People

          • Assignee:
            Christine Poerschke
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development