Lucene - Core
  1. Lucene - Core
  2. LUCENE-6761

MatchAllDocsQuery should not expose approximations

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This is a relic from when queries had to deal with deleted docs themselves: MatchAllDocsQuery used to return an iterator that matched everything as an approximation and applied live docs in the confirmation phase. But now that live docs are checked on top, it should just returns an efficient Scorer that matches every document.

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a simple patch.

        Show
        Adrien Grand added a comment - Here is a simple patch.
        Hide
        ASF subversion and git services added a comment -

        Commit 1700754 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1700754 ]

        LUCENE-6761: MatchAllDocsQuery's Scorers do not expose approximations anymore.

        Show
        ASF subversion and git services added a comment - Commit 1700754 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1700754 ] LUCENE-6761 : MatchAllDocsQuery's Scorers do not expose approximations anymore.
        Hide
        ASF subversion and git services added a comment -

        Commit 1700759 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1700759 ]

        LUCENE-6761: MatchAllDocsQuery's Scorers do not expose approximations anymore.

        Show
        ASF subversion and git services added a comment - Commit 1700759 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1700759 ] LUCENE-6761 : MatchAllDocsQuery's Scorers do not expose approximations anymore.

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development