Lucene - Core
  1. Lucene - Core
  2. LUCENE-676

Promote solr's PrefixFilter into Java Lucene's core

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: core/search
    • Labels:
      None

      Description

      Solr's PrefixFilter class is not specific to Solr and seems to be of interest to core lucene users (PyLucene in this case).
      Promoting it into the Lucene core would be helpful.

      1. PrefixFilter.java
        2 kB
        Andi Vajda
      2. TestPrefixFilter.java
        2 kB
        Andi Vajda

        Activity

        Hide
        Andi Vajda added a comment -

        Attached is a version of PrefixFilter that could be added to the Lucene core as submitted by Yura Smolsky, a PyLucene user.

        Show
        Andi Vajda added a comment - Attached is a version of PrefixFilter that could be added to the Lucene core as submitted by Yura Smolsky, a PyLucene user.
        Hide
        Hoss Man added a comment -

        Even though i use PrefixFilter on a daily basis in Solr, and i am confident of it's correctness, I don't think anything should be commited/promoted to the Lucene code base without some Unit Tests.

        (PrefixFilter is exercised by a few tests in the Solr code base at the moment but they aren't portable because they go through the SolrCore)

        Show
        Hoss Man added a comment - Even though i use PrefixFilter on a daily basis in Solr, and i am confident of it's correctness, I don't think anything should be commited/promoted to the Lucene code base without some Unit Tests. (PrefixFilter is exercised by a few tests in the Solr code base at the moment but they aren't portable because they go through the SolrCore)
        Hide
        Andi Vajda added a comment -

        Here is another attachment by Yura providing the request unit test.

        Show
        Andi Vajda added a comment - Here is another attachment by Yura providing the request unit test.
        Hide
        Yonik Seeley added a comment -

        The test was incorrect. I fixed it, added some more tests, and committed.

        Show
        Yonik Seeley added a comment - The test was incorrect. I fixed it, added some more tests, and committed.

          People

          • Assignee:
            Yonik Seeley
            Reporter:
            Andi Vajda
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development