Lucene - Core
  1. Lucene - Core
  2. LUCENE-6755

more tests of ToChildBlockJoinScorer.advance

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I recently helped diagnose some strange errors with ToChildBlockJoinQuery in an older version of Solr which lead me to realize that the problem seemed to have been fixed by LUCENE-6593 – however the tests Adrien added in that issue focused specifically the interaction of ToChildBlockJoinScorer with with the (fairly new) aproximations support in Scorers (evidently that was trigger that caused Adrien to investigate and make the fixes).

      However, in my initial diagnoses / testing, there were at least 2 (non aproximation based) situations where the old code was problematic:

      • ToChildBlockJoinScorer.advance didn't satisfy the "nextDoc equivilent behavior" contract in the special case where the first doc in a segment was a parent w/o any kids
      • in indexes that used multiple levels of hierarchy, a BooleanQuery that combined multiple ToChildBlockJoinQueries using different parent filters – ie: "find docs that are children of X and grandchildren of Y"

      As mentioned, Adrien's changes in LUCENE-6593 seemed to fix both of these problematic situations, but I'm opening this issue to track the addition of some new tests to explicitly cover these situations to protect us against future regression.

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit 1696834 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1696834 ]

          LUCENE-6755: more tests of ToChildBlockJoinScorer.advance

          Show
          ASF subversion and git services added a comment - Commit 1696834 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1696834 ] LUCENE-6755 : more tests of ToChildBlockJoinScorer.advance
          Hide
          ASF subversion and git services added a comment -

          Commit 1696837 from hossman@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1696837 ]

          LUCENE-6755: more tests of ToChildBlockJoinScorer.advance (merge r1696834)

          Show
          ASF subversion and git services added a comment - Commit 1696837 from hossman@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1696837 ] LUCENE-6755 : more tests of ToChildBlockJoinScorer.advance (merge r1696834)
          Hide
          ASF subversion and git services added a comment -

          Commit 1696867 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1696867 ]

          LUCENE-6755: fix test bug and increase num of docs to improve chances of random query matching

          Show
          ASF subversion and git services added a comment - Commit 1696867 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1696867 ] LUCENE-6755 : fix test bug and increase num of docs to improve chances of random query matching
          Hide
          ASF subversion and git services added a comment -

          Commit 1696870 from hossman@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1696870 ]

          LUCENE-6755: fix test bug and increase num of docs to improve chances of random query matching (merge r1696867)

          Show
          ASF subversion and git services added a comment - Commit 1696870 from hossman@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1696870 ] LUCENE-6755 : fix test bug and increase num of docs to improve chances of random query matching (merge r1696867)
          Hide
          Adrien Grand added a comment -

          Thanks for adding those tests Hoss!

          Show
          Adrien Grand added a comment - Thanks for adding those tests Hoss!

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development