Lucene - Core
  1. Lucene - Core
  2. LUCENE-6729

Upgrade ASM version to 5.0.4 (expressions / Solr's TIKA)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4
    • Component/s: modules/expressions
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The expressions module currently uses ASM 4 for generating class files. We should upgrade to ASM 5.0.4. In addition, with that version we can create Java 8 class files on trunk.

      There is a clash with Apache TIKA, which uses the same old 4.x version. But ASM 5 is still compatible to ASM 4, if you pass the old ASM version to your own visitors. But on long term TIKA should upgrade, too, because currently it cannot parse Java 8 class files.

      ASM 5.0 also fixes some bugs with Java 7 class files, so we should really upgrade.

      1. LUCENE-6729.patch
        5 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment -

          Simple patch.

          In branch 5.x, the JavascriptCompiler changes would be omitted (Java 7 compatible class files).

          Show
          Uwe Schindler added a comment - Simple patch. In branch 5.x, the JavascriptCompiler changes would be omitted (Java 7 compatible class files).
          Hide
          Ryan Ernst added a comment -

          +1

          Show
          Ryan Ernst added a comment - +1
          Hide
          ASF subversion and git services added a comment -

          Commit 1695169 from Uwe Schindler in branch 'dev/trunk'
          [ https://svn.apache.org/r1695169 ]

          LUCENE-6729: Upgrade ASM used in expressions module to version 5.0.4

          Show
          ASF subversion and git services added a comment - Commit 1695169 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1695169 ] LUCENE-6729 : Upgrade ASM used in expressions module to version 5.0.4
          Hide
          ASF subversion and git services added a comment -

          Commit 1695172 from Uwe Schindler in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1695172 ]

          Merged revision(s) 1695169 from lucene/dev/trunk:
          LUCENE-6729: Upgrade ASM used in expressions module to version 5.0.4

          Show
          ASF subversion and git services added a comment - Commit 1695172 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1695172 ] Merged revision(s) 1695169 from lucene/dev/trunk: LUCENE-6729 : Upgrade ASM used in expressions module to version 5.0.4
          Hide
          ASF subversion and git services added a comment -

          Commit 1695657 from Uwe Schindler in branch 'dev/trunk'
          [ https://svn.apache.org/r1695657 ]

          LUCENE-6729: Expressions: Remove no longer needed Javadocs comments inside anyonymous visitor

          Show
          ASF subversion and git services added a comment - Commit 1695657 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1695657 ] LUCENE-6729 : Expressions: Remove no longer needed Javadocs comments inside anyonymous visitor
          Hide
          ASF subversion and git services added a comment -

          Commit 1695658 from Uwe Schindler in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1695658 ]

          Merged revision(s) 1695657 from lucene/dev/trunk:
          LUCENE-6729: Expressions: Remove no longer needed Javadocs comments inside anyonymous visitor

          Show
          ASF subversion and git services added a comment - Commit 1695658 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1695658 ] Merged revision(s) 1695657 from lucene/dev/trunk: LUCENE-6729 : Expressions: Remove no longer needed Javadocs comments inside anyonymous visitor

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development