Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      SpanPayloadCheckQuery currently takes a Collection<byte[]> to check its payloads against. This is suboptimal a) because payloads internally use BytesRef rather than byte[] and b) Collection is unordered, but the implementation does actually care about the order in which the payloads appear.

      We should change the constructor to take a List<BytesRef> instead.

      1. LUCENE-6716.patch
        23 kB
        Alan Woodward

        Activity

        Hide
        David Smiley added a comment -

        +1 LGTM. I assumed you renamed the test in the patch; I didn't look at that part line by line.

        Separately, IMO PayloadSpanCollector should be marked as @lucene.experimental as it still has the sad Collection<byte[]> API.

        Show
        David Smiley added a comment - +1 LGTM. I assumed you renamed the test in the patch; I didn't look at that part line by line. Separately, IMO PayloadSpanCollector should be marked as @lucene.experimental as it still has the sad Collection<byte[]> API.
        Hide
        ASF subversion and git services added a comment -

        Commit 1702872 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1702872 ]

        LUCENE-6716: Change SpanPayloadCheckQuery to take List<BytesRef>

        Show
        ASF subversion and git services added a comment - Commit 1702872 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1702872 ] LUCENE-6716 : Change SpanPayloadCheckQuery to take List<BytesRef>
        Hide
        ASF subversion and git services added a comment -

        Commit 1702877 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1702877 ]

        LUCENE-6716: Better toString() for SpanPayloadCheckQuery

        Show
        ASF subversion and git services added a comment - Commit 1702877 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1702877 ] LUCENE-6716 : Better toString() for SpanPayloadCheckQuery
        Hide
        ASF subversion and git services added a comment -

        Commit 1702892 from Alan Woodward in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1702892 ]

        LUCENE-6716: Change SpanPayloadCheckQuery to take List<BytesRef>

        Show
        ASF subversion and git services added a comment - Commit 1702892 from Alan Woodward in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1702892 ] LUCENE-6716 : Change SpanPayloadCheckQuery to take List<BytesRef>
        Hide
        Alan Woodward added a comment -

        Thanks for the review David. PayloadSpanCollector will be dealt with in LUCENE-6489, which I'm working on now.

        Show
        Alan Woodward added a comment - Thanks for the review David. PayloadSpanCollector will be dealt with in LUCENE-6489 , which I'm working on now.

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development