[LUCENE-6706] Support Payload scoring for all SpanQueries - ASF JIRA

Hide

Permalink

Alan Woodward added a comment - 30/Jul/15 10:42

I think rather than having a whole bunch of Span*Query clones that deal with Payloads, this would be better done by having a generic PayloadSpanQuery that wraps another SpanQuery and takes a payload function. The new spancollection API should make this pretty easy - let me see if I can work something up for it.

Show

Alan Woodward added a comment - 30/Jul/15 10:42 I think rather than having a whole bunch of Span*Query clones that deal with Payloads, this would be better done by having a generic PayloadSpanQuery that wraps another SpanQuery and takes a payload function. The new spancollection API should make this pretty easy - let me see if I can work something up for it.

Hide

Permalink

Jamie Johnson added a comment - 30/Jul/15 10:47 - edited

Sounds reasonable to me. I had considered making larger changes like what you are suggesting but decided to get the functionality working with as minimal changes to the other classes. That said I think your suggestion should be the path forward as it provides support to the span family of queries.

Show

Jamie Johnson added a comment - 30/Jul/15 10:47 - edited Sounds reasonable to me. I had considered making larger changes like what you are suggesting but decided to get the functionality working with as minimal changes to the other classes. That said I think your suggestion should be the path forward as it provides support to the span family of queries.

Hide

Permalink

Alan Woodward added a comment - 30/Jul/15 15:27

Here's a patch adding a new PayloadScoreQuery that takes a SpanQuery and a PayloadFunction. PayloadTermQuery and PayloadNearQuery are deprecated.

Show

Alan Woodward added a comment - 30/Jul/15 15:27 Here's a patch adding a new PayloadScoreQuery that takes a SpanQuery and a PayloadFunction. PayloadTermQuery and PayloadNearQuery are deprecated.

Hide

Permalink

ASF subversion and git services added a comment - 03/Aug/15 15:49

Commit 1693921 from Alan Woodward in branch 'dev/trunk'
[ https://svn.apache.org/r1693921 ]

~~LUCENE-6706~~: Add PayloadScoreQuery

Show

ASF subversion and git services added a comment - 03/Aug/15 15:49 Commit 1693921 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1693921 ] LUCENE-6706 : Add PayloadScoreQuery

Hide

Permalink

ASF subversion and git services added a comment - 03/Aug/15 15:58

Commit 1693924 from Alan Woodward in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1693924 ]

~~LUCENE-6706~~: Add PayloadScoreQuery

Show

ASF subversion and git services added a comment - 03/Aug/15 15:58 Commit 1693924 from Alan Woodward in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1693924 ] LUCENE-6706 : Add PayloadScoreQuery

Hide

Permalink

ASF subversion and git services added a comment - 03/Aug/15 16:15

Commit 1693927 from Alan Woodward in branch 'dev/trunk'
[ https://svn.apache.org/r1693927 ]

~~LUCENE-6706~~: Remove deprecated PayloadTermQuery and PayloadNearQuery

Show

ASF subversion and git services added a comment - 03/Aug/15 16:15 Commit 1693927 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1693927 ] LUCENE-6706 : Remove deprecated PayloadTermQuery and PayloadNearQuery

Hide

Permalink

Alan Woodward added a comment - 03/Aug/15 16:16

Thanks Jamie!

Show

Alan Woodward added a comment - 03/Aug/15 16:16 Thanks Jamie!

Hide

Permalink

Jamie Johnson added a comment - 03/Aug/15 16:18

Thanks Alan, I really appreciate the quick turn around on this.

Show

Jamie Johnson added a comment - 03/Aug/15 16:18 Thanks Alan, I really appreciate the quick turn around on this.

Hide

Permalink

Steve Rowe added a comment - 03/Aug/15 16:46

Compilation is failing on trunk in the queryparser module:

common.compile-core:
    [mkdir] Created dir: /Users/sarowe/svn/lucene/dev/trunk/lucene/build/queryparser/classes/java
    [javac] Compiling 224 source files to /Users/sarowe/svn/lucene/dev/trunk/lucene/build/queryparser/classes/java
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BoostingTermBuilder.java:5: error: cannot find symbol
    [javac] import org.apache.lucene.search.payloads.PayloadTermQuery;
    [javac]                                         ^
    [javac]   symbol:   class PayloadTermQuery
    [javac]   location: package org.apache.lucene.search.payloads
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BoostingTermBuilder.java:29: error: reference not found
    [javac]  * Builder for {@link PayloadTermQuery}
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/QueryParserTokenManager.java:493: warning: [cast] redundant cast to int
    [javac]          int hiByte = (int)(curChar >> 8);
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/QueryParserTokenManager.java:687: warning: [cast] redundant cast to int
    [javac]          int hiByte = (int)(curChar >> 8);
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/QueryParserTokenManager.java:860: warning: [cast] redundant cast to int
    [javac]          int hiByte = (int)(curChar >> 8);
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/config/NumericConfig.java:32: warning: [overrides] Class NumericConfig overrides equals, but neither it nor any superclass overrides hashCode method
    [javac] public class NumericConfig {
    [javac]        ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParserTokenManager.java:375: warning: [cast] redundant cast to int
    [javac]          int hiByte = (int)(curChar >> 8);
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParserTokenManager.java:495: warning: [cast] redundant cast to int
    [javac]          int hiByte = (int)(curChar >> 8);
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParserTokenManager.java:668: warning: [cast] redundant cast to int
    [javac]          int hiByte = (int)(curChar >> 8);
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/parser/QueryParserTokenManager.java:348: warning: [cast] redundant cast to int
    [javac]          int hiByte = (int)(curChar >> 8);
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/parser/QueryParserTokenManager.java:468: warning: [cast] redundant cast to int
    [javac]          int hiByte = (int)(curChar >> 8);
    [javac]                       ^
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/RewriteQuery.java:64: warning: [rawtypes] found raw type: RewriteQuery
    [javac]     RewriteQuery other = (RewriteQuery)obj;
    [javac]     ^
    [javac]   missing type arguments for generic class RewriteQuery<SQ>
    [javac]   where SQ is a type-variable:
    [javac]     SQ extends SrndQuery declared in class RewriteQuery
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/OrQuery.java:43: warning: [rawtypes] found raw type: Iterator
    [javac]     Iterator sqi = getSubQueriesIterator();
    [javac]     ^
    [javac]   missing type arguments for generic class Iterator<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in interface Iterator
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/OrQuery.java:60: warning: [rawtypes] found raw type: Iterator
    [javac]     Iterator sqi = getSubQueriesIterator();
    [javac]     ^
    [javac]   missing type arguments for generic class Iterator<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in interface Iterator
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/QueryTemplateManager.java:179: warning: [rawtypes] found raw type: Enumeration
    [javac]     Enumeration keysEnum = formProperties.keys();
    [javac]     ^
    [javac]   missing type arguments for generic class Enumeration<E>
    [javac]   where E is a type-variable:
    [javac]     E extends Object declared in interface Enumeration
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BoostingTermBuilder.java:38: error: cannot find symbol
    [javac]     PayloadTermQuery btq = new PayloadTermQuery(new Term(fieldName, value), new AveragePayloadFunction());
    [javac]     ^
    [javac]   symbol:   class PayloadTermQuery
    [javac]   location: class BoostingTermBuilder
    [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BoostingTermBuilder.java:38: error: cannot find symbol
    [javac]     PayloadTermQuery btq = new PayloadTermQuery(new Term(fieldName, value), new AveragePayloadFunction());
    [javac]                                ^
    [javac]   symbol:   class PayloadTermQuery
    [javac]   location: class BoostingTermBuilder
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 4 errors
    [javac] 13 warnings

Show

Steve Rowe added a comment - 03/Aug/15 16:46 Compilation is failing on trunk in the queryparser module: common.compile-core: [mkdir] Created dir: /Users/sarowe/svn/lucene/dev/trunk/lucene/build/queryparser/classes/java [javac] Compiling 224 source files to /Users/sarowe/svn/lucene/dev/trunk/lucene/build/queryparser/classes/java [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BoostingTermBuilder.java:5: error: cannot find symbol [javac] import org.apache.lucene.search.payloads.PayloadTermQuery; [javac] ^ [javac] symbol: class PayloadTermQuery [javac] location: package org.apache.lucene.search.payloads [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BoostingTermBuilder.java:29: error: reference not found [javac] * Builder for {@link PayloadTermQuery} [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/QueryParserTokenManager.java:493: warning: [cast] redundant cast to int [javac] int hiByte = (int)(curChar >> 8); [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/QueryParserTokenManager.java:687: warning: [cast] redundant cast to int [javac] int hiByte = (int)(curChar >> 8); [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/QueryParserTokenManager.java:860: warning: [cast] redundant cast to int [javac] int hiByte = (int)(curChar >> 8); [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/config/NumericConfig.java:32: warning: [overrides] Class NumericConfig overrides equals, but neither it nor any superclass overrides hashCode method [javac] public class NumericConfig { [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParserTokenManager.java:375: warning: [cast] redundant cast to int [javac] int hiByte = (int)(curChar >> 8); [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParserTokenManager.java:495: warning: [cast] redundant cast to int [javac] int hiByte = (int)(curChar >> 8); [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParserTokenManager.java:668: warning: [cast] redundant cast to int [javac] int hiByte = (int)(curChar >> 8); [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/parser/QueryParserTokenManager.java:348: warning: [cast] redundant cast to int [javac] int hiByte = (int)(curChar >> 8); [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/parser/QueryParserTokenManager.java:468: warning: [cast] redundant cast to int [javac] int hiByte = (int)(curChar >> 8); [javac] ^ [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/RewriteQuery.java:64: warning: [rawtypes] found raw type: RewriteQuery [javac] RewriteQuery other = (RewriteQuery)obj; [javac] ^ [javac] missing type arguments for generic class RewriteQuery<SQ> [javac] where SQ is a type-variable: [javac] SQ extends SrndQuery declared in class RewriteQuery [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/OrQuery.java:43: warning: [rawtypes] found raw type: Iterator [javac] Iterator sqi = getSubQueriesIterator(); [javac] ^ [javac] missing type arguments for generic class Iterator<E> [javac] where E is a type-variable: [javac] E extends Object declared in interface Iterator [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/surround/query/OrQuery.java:60: warning: [rawtypes] found raw type: Iterator [javac] Iterator sqi = getSubQueriesIterator(); [javac] ^ [javac] missing type arguments for generic class Iterator<E> [javac] where E is a type-variable: [javac] E extends Object declared in interface Iterator [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/QueryTemplateManager.java:179: warning: [rawtypes] found raw type: Enumeration [javac] Enumeration keysEnum = formProperties.keys(); [javac] ^ [javac] missing type arguments for generic class Enumeration<E> [javac] where E is a type-variable: [javac] E extends Object declared in interface Enumeration [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BoostingTermBuilder.java:38: error: cannot find symbol [javac] PayloadTermQuery btq = new PayloadTermQuery(new Term(fieldName, value), new AveragePayloadFunction()); [javac] ^ [javac] symbol: class PayloadTermQuery [javac] location: class BoostingTermBuilder [javac] /Users/sarowe/svn/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/BoostingTermBuilder.java:38: error: cannot find symbol [javac] PayloadTermQuery btq = new PayloadTermQuery(new Term(fieldName, value), new AveragePayloadFunction()); [javac] ^ [javac] symbol: class PayloadTermQuery [javac] location: class BoostingTermBuilder [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] 4 errors [javac] 13 warnings

Hide

Permalink

Alan Woodward added a comment - 03/Aug/15 16:48

Bah, sorry Steve, will fix.

Show

Alan Woodward added a comment - 03/Aug/15 16:48 Bah, sorry Steve, will fix.

Hide

Permalink

ASF subversion and git services added a comment - 03/Aug/15 16:53

Commit 1693933 from Alan Woodward in branch 'dev/trunk'
[ https://svn.apache.org/r1693933 ]

~~LUCENE-6706~~: Commit from the right directory this time

Show

ASF subversion and git services added a comment - 03/Aug/15 16:53 Commit 1693933 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1693933 ] LUCENE-6706 : Commit from the right directory this time

Hide

Permalink

Steve Rowe added a comment - 04/Aug/15 01:03

Reproduces for me on branch_5x/win7/java8: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Windows/4974/:

   [junit4] Suite: org.apache.lucene.search.payloads.TestPayloadScoreQuery
   [junit4]   2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory.
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestPayloadScoreQuery -Dtests.method=testSpanContainingQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e
:/Lucene_data/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252
   [junit4] FAILURE 0.12s | TestPayloadScoreQuery.testSpanContainingQuery <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: Unexpected hit in document 296
   [junit4]    >        at __randomizedtesting.SeedInfo.seed([5A58A589322E17:8964B028249CFB65]:0)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testSpanContainingQuery(TestPayloadScoreQuery.java:152)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory.
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestPayloadScoreQuery -Dtests.method=testNearQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e:/Lucene_d
ata/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252
   [junit4] FAILURE 0.01s | TestPayloadScoreQuery.testNearQuery <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: Unexpected hit in document 296
   [junit4]    >        at __randomizedtesting.SeedInfo.seed([5A58A589322E17:40BA355A8FFBB4DB]:0)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testNearQuery(TestPayloadScoreQuery.java:112)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory.
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestPayloadScoreQuery -Dtests.method=testOrQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e:/Lucene_data/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252
   [junit4] FAILURE 0.01s | TestPayloadScoreQuery.testOrQuery <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: Unexpected hit in document 292
   [junit4]    >        at __randomizedtesting.SeedInfo.seed([5A58A589322E17:603E139078605B5F]:0)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testOrQuery(TestPayloadScoreQuery.java:93)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory.
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestPayloadScoreQuery -Dtests.method=testTermQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e:/Lucene_data/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252
   [junit4] FAILURE 0.01s | TestPayloadScoreQuery.testTermQuery <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: Unexpected hit in document 292
   [junit4]    >        at __randomizedtesting.SeedInfo.seed([5A58A589322E17:BF4CC9B6B5DEAF7]:0)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testTermQuery(TestPayloadScoreQuery.java:80)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory.
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestPayloadScoreQuery -Dtests.method=testNestedNearQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e:/Lucene_data/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252
   [junit4] FAILURE 0.02s | TestPayloadScoreQuery.testNestedNearQuery <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: Unexpected hit in document 296
   [junit4]    >        at __randomizedtesting.SeedInfo.seed([5A58A589322E17:42ABC93E88608A50]:0)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66)
   [junit4]    >        at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testNestedNearQuery(TestPayloadScoreQuery.java:134)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: test params are: codec=Asserting(Lucene53): {field=Lucene50(blocksize=128), field2=PostingsFormat(name=Asserting)}, docValues:{}, sim=DefaultSimilarity, locale=nl_BE, timezone=US/Samoa
   [junit4]   2> NOTE: Windows 7 6.1 amd64/Oracle Corporation 1.8.0_20 (64-bit)/cpus=8,threads=1,free=99534872,total=124780544
   [junit4]   2> NOTE: All tests run in this JVM: [TestPayloadScoreQuery]

Show

Steve Rowe added a comment - 04/Aug/15 01:03 Reproduces for me on branch_5x/win7/java8: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Windows/4974/ : [junit4] Suite: org.apache.lucene.search.payloads.TestPayloadScoreQuery [junit4] 2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory. [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestPayloadScoreQuery -Dtests.method=testSpanContainingQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e :/Lucene_data/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252 [junit4] FAILURE 0.12s | TestPayloadScoreQuery.testSpanContainingQuery <<< [junit4] > Throwable #1: java.lang.AssertionError: Unexpected hit in document 296 [junit4] > at __randomizedtesting.SeedInfo.seed([5A58A589322E17:8964B028249CFB65]:0) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testSpanContainingQuery(TestPayloadScoreQuery.java:152) [junit4] > at java.lang.Thread.run(Thread.java:745) [junit4] 2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory. [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestPayloadScoreQuery -Dtests.method=testNearQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e:/Lucene_d ata/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252 [junit4] FAILURE 0.01s | TestPayloadScoreQuery.testNearQuery <<< [junit4] > Throwable #1: java.lang.AssertionError: Unexpected hit in document 296 [junit4] > at __randomizedtesting.SeedInfo.seed([5A58A589322E17:40BA355A8FFBB4DB]:0) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testNearQuery(TestPayloadScoreQuery.java:112) [junit4] > at java.lang.Thread.run(Thread.java:745) [junit4] 2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory. [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestPayloadScoreQuery -Dtests.method=testOrQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e:/Lucene_data/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252 [junit4] FAILURE 0.01s | TestPayloadScoreQuery.testOrQuery <<< [junit4] > Throwable #1: java.lang.AssertionError: Unexpected hit in document 292 [junit4] > at __randomizedtesting.SeedInfo.seed([5A58A589322E17:603E139078605B5F]:0) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testOrQuery(TestPayloadScoreQuery.java:93) [junit4] > at java.lang.Thread.run(Thread.java:745) [junit4] 2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory. [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestPayloadScoreQuery -Dtests.method=testTermQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e:/Lucene_data/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252 [junit4] FAILURE 0.01s | TestPayloadScoreQuery.testTermQuery <<< [junit4] > Throwable #1: java.lang.AssertionError: Unexpected hit in document 292 [junit4] > at __randomizedtesting.SeedInfo.seed([5A58A589322E17:BF4CC9B6B5DEAF7]:0) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testTermQuery(TestPayloadScoreQuery.java:80) [junit4] > at java.lang.Thread.run(Thread.java:745) [junit4] 2> NOTE: download the large Jenkins line-docs file by running 'ant get-jenkins-line-docs' in the lucene directory. [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestPayloadScoreQuery -Dtests.method=testNestedNearQuery -Dtests.seed=5A58A589322E17 -Dtests.slow=true -Dtests.linedocsfile=e:/Lucene_data/enwiki.random.lines.txt -Dtests.locale=nl_BE -Dtests.timezone=US/Samoa -Dtests.asserts=true -Dtests.file.encoding=Cp1252 [junit4] FAILURE 0.02s | TestPayloadScoreQuery.testNestedNearQuery <<< [junit4] > Throwable #1: java.lang.AssertionError: Unexpected hit in document 296 [junit4] > at __randomizedtesting.SeedInfo.seed([5A58A589322E17:42ABC93E88608A50]:0) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.checkQuery(TestPayloadScoreQuery.java:66) [junit4] > at org.apache.lucene.search.payloads.TestPayloadScoreQuery.testNestedNearQuery(TestPayloadScoreQuery.java:134) [junit4] > at java.lang.Thread.run(Thread.java:745) [junit4] 2> NOTE: test params are: codec=Asserting(Lucene53): {field=Lucene50(blocksize=128), field2=PostingsFormat(name=Asserting)}, docValues:{}, sim=DefaultSimilarity, locale=nl_BE, timezone=US/Samoa [junit4] 2> NOTE: Windows 7 6.1 amd64/Oracle Corporation 1.8.0_20 (64-bit)/cpus=8,threads=1,free=99534872,total=124780544 [junit4] 2> NOTE: All tests run in this JVM: [TestPayloadScoreQuery]

Hide

Permalink

Hoss Man added a comment - 04/Aug/15 01:09

re-opened due to test failures

Show

Hoss Man added a comment - 04/Aug/15 01:09 re-opened due to test failures

Hide

Permalink

ASF subversion and git services added a comment - 04/Aug/15 12:54

Commit 1694050 from Alan Woodward in branch 'dev/trunk'
[ https://svn.apache.org/r1694050 ]

~~LUCENE-6706~~: Fix test bug

Show

ASF subversion and git services added a comment - 04/Aug/15 12:54 Commit 1694050 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1694050 ] LUCENE-6706 : Fix test bug

Hide

Permalink

ASF subversion and git services added a comment - 04/Aug/15 12:56

Commit 1694051 from Alan Woodward in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1694051 ]

~~LUCENE-6706~~: Fix test bug

Show

ASF subversion and git services added a comment - 04/Aug/15 12:56 Commit 1694051 from Alan Woodward in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1694051 ] LUCENE-6706 : Fix test bug

Hide

Permalink

Alan Woodward added a comment - 04/Aug/15 12:57

The tests were expecting docids to be stable, but some were being re-ordered by the random merge policy. I set them to use NoMergePolicy instead.

Show

Alan Woodward added a comment - 04/Aug/15 12:57 The tests were expecting docids to be stable, but some were being re-ordered by the random merge policy. I set them to use NoMergePolicy instead.

Hide

Permalink

Shalin Shekhar Mangar added a comment - 26/Aug/15 13:06

Bulk close for 5.3.0 release

Show

Shalin Shekhar Mangar added a comment - 26/Aug/15 13:06 Bulk close for 5.3.0 release

Support Payload scoring for all SpanQueries

Details

Description

Attachments

Activity

People

Dates

Development

Agile