[LUCENE-6691] tweak SortingMergePolicy.getSortDescription

• Type: Test
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.3, 6.0
• Lucene Fields: New
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 21/Jul/15 13:06
• Updated: 28/Aug/22 14:39
• Resolved: 04/Aug/15 16:11

Description

Building tests for SOLR-5730 identified that early termination can be omitted for sorted segments because the LeafReader concerned is not a SegmentReader - github pull request to illustrate to follow:

• the TestEarlyTerminatingSortingCollector.testTerminatedEarly test uses a wrapped reader in the same way as SolrIndexSearcher
• the SortingMergePolicy.getSortDescription change (assuming it is a valid change to make) fixes that particular test only
• ExitableDirectoryReader and UninvertingReader wrap could perhaps also be added in LuceneTestCase.wrapReader ?

LUCENE-6065 "remove "foreign readers" from merge, fix LeafReader instead." also concerns SortingMergePolicy.

Issue Links

• is required by: SOLR-5730 make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr