Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6691

tweak SortingMergePolicy.getSortDescription

    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 5.3, 6.0
    • None
    • None
    • New

    Description

      Building tests for SOLR-5730 identified that early termination can be omitted for sorted segments because the LeafReader concerned is not a SegmentReader - github pull request to illustrate to follow:

      • the TestEarlyTerminatingSortingCollector.testTerminatedEarly test uses a wrapped reader in the same way as SolrIndexSearcher
      • the SortingMergePolicy.getSortDescription change (assuming it is a valid change to make) fixes that particular test only
      • ExitableDirectoryReader and UninvertingReader wrap could perhaps also be added in LuceneTestCase.wrapReader ?

      LUCENE-6065 "remove "foreign readers" from merge, fix LeafReader instead." also concerns SortingMergePolicy.

      Attachments

        Issue Links

          Activity

            People

              cpoerschke Christine Poerschke
              cpoerschke Christine Poerschke
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: