Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6634

PKIndexSplitter should take queries, not filters

        Details

        • Type: Task
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 5.3
        • Component/s: None
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          We could make PKIndexSplitter work on the Query API instead of Filter. This way lucene/misc would not depend on oal.search.Filter anymore.

          1. Text File
            LUCENE-6634.patch
            6 kB
            Adrien Grand
          2. Text File
            LUCENE-6634.patch
            5 kB
            Adrien Grand

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jpountz Adrien Grand added a comment -

            Here is a patch. The change is backward compatible since Filter extends Query.

            Show
            jpountz Adrien Grand added a comment - Here is a patch. The change is backward compatible since Filter extends Query.
            Hide
            Permalink
            thetaphi Uwe Schindler added a comment -

            Looks fine. Change is almost backwards compatible (but you need to recompile for correct method signatures). So maybe add the Filter constructor (just deprecate) for full backwards compatibility.

            Show
            thetaphi Uwe Schindler added a comment - Looks fine. Change is almost backwards compatible (but you need to recompile for correct method signatures). So maybe add the Filter constructor (just deprecate) for full backwards compatibility.
            Hide
            Permalink
            jpountz Adrien Grand added a comment -

            OK, I will do that when merging to 5.x. Thanks for having a look!

            Show
            jpountz Adrien Grand added a comment - OK, I will do that when merging to 5.x. Thanks for having a look!
            Hide
            Permalink
            thetaphi Uwe Schindler added a comment -

            Maybe you rename the local variables, partially they are still named preserveFilter instead of preserveWeight,... But thats just for consistency.

            Thanks for having a look!

            I had to, I wrote that code back in Lucene 3.x and modified for 4.0

            Show
            thetaphi Uwe Schindler added a comment - Maybe you rename the local variables, partially they are still named preserveFilter instead of preserveWeight,... But thats just for consistency. Thanks for having a look! I had to, I wrote that code back in Lucene 3.x and modified for 4.0
            Hide
            Permalink
            jpountz Adrien Grand added a comment -

            I changed the name to preserveWeight when it becomes a Weight. However I kept preserveFilter when it is still a Query as I think it nicely conveys the fact that scores won't be used?

            Show
            jpountz Adrien Grand added a comment - I changed the name to preserveWeight when it becomes a Weight. However I kept preserveFilter when it is still a Query as I think it nicely conveys the fact that scores won't be used?
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1688365 from Adrien Grand in branch 'dev/trunk'
            [ https://svn.apache.org/r1688365 ]

            LUCENE-6634: PKIndexSplitter now takes a Query instead of a Filter.

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1688365 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1688365 ] LUCENE-6634 : PKIndexSplitter now takes a Query instead of a Filter.
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1688368 from Adrien Grand in branch 'dev/branches/branch_5x'
            [ https://svn.apache.org/r1688368 ]

            LUCENE-6634: PKIndexSplitter now takes a Query instead of a Filter.

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1688368 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1688368 ] LUCENE-6634 : PKIndexSplitter now takes a Query instead of a Filter.
            Hide
            Permalink
            thetaphi Uwe Schindler added a comment -

            Thanks!

            Show
            thetaphi Uwe Schindler added a comment - Thanks!
            Hide
            Permalink
            shalinmangar Shalin Shekhar Mangar added a comment -

            Bulk close for 5.3.0 release

            Show
            shalinmangar Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

              People

              • Assignee:
                jpountz Adrien Grand
                Reporter:
                jpountz Adrien Grand
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development